Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FE system message for new stream created #1954

Closed
elatif2020 opened this issue Aug 10, 2023 · 3 comments · Fixed by #1956
Closed

Add FE system message for new stream created #1954

elatif2020 opened this issue Aug 10, 2023 · 3 comments · Fixed by #1956
Assignees
@andreymikhadyuk
Labels
Priority - A V [dev] verified on dev enviroment V [production] verified on production enviroment

Comments

@elatif2020
Copy link
Collaborator

elatif2020 commented Aug 10, 2023 •
edited
Loading

BE ticket
https://github.com/daostack/common-backend/issues/1950
@andreymikhadyuk
Copy link
Collaborator

andreymikhadyuk commented Aug 11, 2023 •
edited
Loading

@elatif2020 I see in the BE ticket that feed item title should be a link to the feed item.
How should it work? Clicking the title we should make that feed item active? What should happen if that feed item is not loaded yet (e.g. it is in the next batch of data for feed item)? Should we display such item at the top of the list under pinned items?

@andreymikhadyuk andreymikhadyuk linked a pull request Aug 11, 2023 that will close this issue
Add FE system message for new stream created - Use BE text #1954 #1956
Merged
3 tasks
andreymikhadyuk added a commit that referenced this issue Aug 11, 2023
@andreymikhadyuk
Merge pull request #1956 from daostack/feature/CW-1954-new-stream-sys…
e5ab376 
…tem-message

Add FE system message for new stream created - Use BE text #1954
@andreymikhadyuk
Copy link
Collaborator

@elatif2020 @NoamQA for now we merged the changes which will display text from BE, so the title of feed item is not clickable. I will do the rest work here once we figure out all questions.

@elatif2020
Copy link
Collaborator Author

@andreymikhadyuk
We probably need this fix also in staging. Is it there?
I'm closing this ticket, will create another ticket for adding the link

@NoamQA NoamQA added V [dev] verified on dev enviroment V [production] verified on production enviroment labels Aug 16, 2023
@elatif2020 elatif2020 mentioned this issue Aug 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreymikhadyuk andreymikhadyuk

Labels
Priority - A V [dev] verified on dev enviroment V [production] verified on production enviroment
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add FE system message for new stream created - Use BE text #1954 daostack/common-web
3 participants
@andreymikhadyuk @elatif2020 @NoamQA