Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE render system messages for new feed item with link #2014

Closed
elatif2020 opened this issue Aug 24, 2023 · 1 comment · Fixed by #2018
Closed

FE render system messages for new feed item with link #2014

elatif2020 opened this issue Aug 24, 2023 · 1 comment · Fixed by #2018
Assignees
Labels
Priority - B V [dev] verified on dev enviroment V [production] verified on production enviroment

Comments

@elatif2020
Copy link
Collaborator

elatif2020 commented Aug 24, 2023

I was thinking originally to add a link to that feed item the same as we have with the url query parameter, but maybe this is not the best solution.
If this item is already rendered we can just make it active.
Otherwise the best would be to scroll down all the way to that item. We should make the scrolling down gradual and can show the loader as we do for loading more items.

@elatif2020 I see in the BE ticket that feed item title should be a link to the feed item.
How should it work? Clicking the title we should make that feed item active? What should happen if that feed item is not loaded yet (e.g. it is in the next batch of data for feed item)? Should we display such item at the top of the list under pinned items?

Originally posted by @andreymikhadyuk in #1954 (comment)

If the item is deleted - remove the link and add "(deleted)" at thee end

@andreymikhadyuk
Copy link
Collaborator

andreymikhadyuk commented Aug 29, 2023

@andreymikhadyuk andreymikhadyuk linked a pull request Aug 29, 2023 that will close this issue
5 tasks
andreymikhadyuk added a commit that referenced this issue Sep 5, 2023
FE render system messages for new feed item with link #2014
@NoamQA NoamQA added the V [dev] verified on dev enviroment label Sep 5, 2023
@NoamQA NoamQA added the V [production] verified on production enviroment label Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority - B V [dev] verified on dev enviroment V [production] verified on production enviroment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants