Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE render system messages for new feed item with link #2014 #2018

Merged
merged 15 commits into from
Sep 5, 2023

Conversation

andreymikhadyuk
Copy link
Collaborator

@andreymikhadyuk andreymikhadyuk commented Aug 29, 2023

  • PR title equals to the ticket name
  • I added the ticket to the Development section of this PR.

What was changed?

  • made discussion in ChatItem to be nullable, so we can activate items from FeedLayout without having discussion data, etc...
  • added click handler to feed-item-created system message's item title
  • added refs to the feed items to have ability to initiate scroll to them

@netlify
Copy link

netlify bot commented Aug 29, 2023

Deploy Preview for preview-common ready!

Name Link
🔨 Latest commit e9cb5de
🔍 Latest deploy log https://app.netlify.com/sites/preview-common/deploys/64f6e7edfb79580008b55715
😎 Deploy Preview https://deploy-preview-2018--preview-common.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andreymikhadyuk andreymikhadyuk marked this pull request as draft August 29, 2023 12:26
@andreymikhadyuk andreymikhadyuk linked an issue Aug 29, 2023 that may be closed by this pull request
@andreymikhadyuk andreymikhadyuk marked this pull request as ready for review August 29, 2023 12:56
@andreymikhadyuk andreymikhadyuk marked this pull request as draft August 29, 2023 14:20
@andreymikhadyuk andreymikhadyuk marked this pull request as ready for review September 5, 2023 09:04
@andreymikhadyuk andreymikhadyuk merged commit 815f2a0 into dev Sep 5, 2023
6 checks passed
@andreymikhadyuk andreymikhadyuk deleted the feature/CW-2014-feed-item-link branch September 5, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FE render system messages for new feed item with link
3 participants