New approval (proposal) card #1864 #1871
Conversation
✅ Deploy Preview for preview-common ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@roienatan Is it ready for review? |
@andreymikhadyuk now yes. |
| --strong-gray: #7a819c; | ||
| --gray-60: #6b718e; | ||
| --red: #ff603e; |
There was a problem hiding this comment.
To be honest I do not see any benefits of adding specific colors (gray, red, etc...) to the css variables.
There was a problem hiding this comment.
@andreymikhadyuk Correct me if I'm wrong but the whole idea of the theme.scss was to create a new file for colors and narrow the colors we have in constants.scss. If not, what's the point of having some colors in theme.scss and some in constants.scss?
There was a problem hiding this comment.
The main reason for theme to have different themes. So the names should be primary, secondary, etc... so that we can have different themes (light, dark) and we can use same name variables. But gray-30 which we use for light theme will be different for dark. As I said previously, designer should provide such specific names for themes. I do not see any reasons to stop using constants.scss and move all variables to css variables of theme.scss.
There was a problem hiding this comment.
I will merge the PR, but anyway I would go further with what I described higher.
src/pages/common/components/ProposalFeedCard/components/VoteButton/VoteButton.tsx
Outdated
Show resolved
Hide resolved
...ents/ProposalFeedCard/components/ProposalFeedButtonContainer/ProposalFeedButtonContainer.tsx
Outdated
Show resolved
Hide resolved
...mponents/ProposalFeedCard/components/ImmediateProposalVoteInfo/ImmediateProposalVoteInfo.tsx
Outdated
Show resolved
Hide resolved
...mponents/ProposalFeedCard/components/ImmediateProposalVoteInfo/ImmediateProposalVoteInfo.tsx
Outdated
Show resolved
Hide resolved
Developmentsection of this PR.What was changed?
resolutionTypeproperty for proposals and change UI accordingly.