Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icons to the chat messages action menu #1906 #1911

Merged
merged 4 commits into from
Aug 4, 2023

Conversation

roienatan
Copy link
Collaborator

@roienatan roienatan commented Aug 1, 2023

  • PR title equals to the ticket name
  • I added the ticket to the Development section of this PR.

What was changed?

  • Chat message action menu: added icons.

@netlify
Copy link

netlify bot commented Aug 1, 2023

Deploy Preview for preview-common ready!

Name Link
🔨 Latest commit da22b04
🔍 Latest deploy log https://app.netlify.com/sites/preview-common/deploys/64cc1fb7167c350008287c8c
😎 Deploy Preview https://deploy-preview-1911--preview-common.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@roienatan roienatan linked an issue Aug 1, 2023 that may be closed by this pull request
@roienatan roienatan marked this pull request as ready for review August 2, 2023 23:10
src/shared/components/ElementDropdown/ElementDropdown.tsx Outdated Show resolved Hide resolved
searchText: "Reply",
value: ElementDropdownMenuItems.Reply,
});
}

if (isOwner && isDiscussionMessage && !isDiscussionMessageWithFile) {
items.push({
text: <span>Edit</span>,
text: (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And will such change work fine for isControlledMenu === true (because DesktopStyleMenu is used for such case)?

@andreymikhadyuk
Copy link
Collaborator

@roienatan please merge if you feel that everything is fine regarding my comment.

@roienatan roienatan merged commit cb7f6c1 into dev Aug 4, 2023
6 checks passed
@roienatan roienatan deleted the cw-1906-chat-message-action-menu-icons branch August 4, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add icons to the chat messages action menu
2 participants