Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash in backpage #2717

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Crash in backpage #2717

merged 2 commits into from
Jul 31, 2024

Conversation

MeyerPV
Copy link
Collaborator

@MeyerPV MeyerPV commented Jul 16, 2024

@MeyerPV MeyerPV requested a review from elatif2020 July 16, 2024 14:19
@netlify Netlify
Copy link

netlify bot commented Jul 16, 2024 •
edited
Loading

✅ Deploy Preview for preview-common ready!

Name Link
🔨 Latest commit cfff514
🔍 Latest deploy log https://app.netlify.com/sites/preview-common/deploys/66aa11707276fe00082075f5
😎 Deploy Preview https://deploy-preview-2717--preview-common.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@elatif2020
Copy link
Collaborator

@MeyerPV I'm still having a crash after reload in the backpage and switching to Members tab, with the console error:
TypeError: joinedAt.toDate is not a function
CommonMember Ember
React 7
unstable_runWithPriority scheduler.production.min.js:18
React 5
_callee$ useGovernance.ts:31
Babel 5

elatif2020
elatif2020 approved these changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@elatif2020 elatif2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good now

@MeyerPV MeyerPV merged commit e5cfcff into dev Jul 31, 2024
5 checks passed
@MeyerPV MeyerPV deleted the CW-crash-backpage branch July 31, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elatif2020 elatif2020 elatif2020 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MeyerPV @elatif2020