901 inner join and semi join with result cardinality hint #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced `numRowRes` as a parameter for `InnerJoin` and `SemiJoin` kernel functions, indicating the size of the result. - In `InnerJoin`: - If `numRowRes` is -1, the result size is set to `numRowRhs * numRowLhs`. - Otherwise, the result size is determined by `numRowRes`. - In `SemiJoin`: - If `numRowRes` is -1, the result size defaults to `numRowLhs`. - Otherwise, the result size is determined by `numRowRes`. - Updated DaphneDSL: - Added `numRowRes` as an optional parameter for `innerJoin` and `semiJoin` built-in functions. - If not provided, `numRowRes` defaults to -1, which is passed to DaphneIR operations. - Modified DaphneIR: - Made `numRowRes` a mandatory argument for `InnerJoinOp` and `SemiJoinOp`. - Implementation Updates: - Updated `DaphneDSLBuiltins.cpp` to handle default `numRowRes` values. - Set `numRowRes` to -1 in `SQLVisitor.cpp` for compatibility. - Adjusted `kernels.json` to reflect the new parameter in `innerJoin` and `semiJoin`. - Added script-level test cases to validate the new functionality. - Addresses issue `daphne-eu#901` by allowing users to specify result size to prevent over-allocation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance Join Operations with Customizable Result Size Allocation
PR Description
Enhancements to Join Operations
This update introduces a new optional parameter,
numRowRes, to the InnerJoin and SemiJoin DaphneDSL Operations, enabling precise control over result size allocation. Addresses issue #901.Key Changes:
Kernel changes:
numRowRes = -1, the result size defaults tonumRowRhs * numRowLhs(cartesian product).numRowRes.numRowRes = -1, the result size defaults tonumRowLhs.numRowRes.DaphneDSL Updates:
numRowResis now an optional argument forinnerJoinandsemiJoin.-1if not provided.DaphneIR Adjustments:
numRowResis now a mandatory argument forInnerJoinOpandSemiJoinOp.Implementation Updates:
DaphneDSLBuiltins.cppto set default values fornumRowRes.SQLVisitor.cppto ensure compatibility by passing-1asnumRowRes.kernels.jsonto reflect the new parameter for relevant operations.Testing:
Bug Fixes