dapp: remappings: use shortest path when deduplicating

dapphub · Sep 8, 2021 · e42da31 · e42da31
1 parent c01b0b5
commit e42da31
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/dapp/libexec/dapp/dapp-remappings b/src/dapp/libexec/dapp/dapp-remappings
@@ -52,7 +52,11 @@ function deduplicate(pkg) {
 // walk tree and build a mapping from hash => path
 function mapHashes(pkg) {
   const go = (mapping, dep) => {
-    mapping[dep.hash] = dep.path
+    // we collect the shortest path (aka closest to the root) for each dep
+    if (mapping[dep.hash] == undefined || dep.path.length < mapping[dep.hash].length) {
+      mapping[dep.hash] = dep.path
+    }
+
     return dep.deps.reduce(go, mapping)
   }
   return pkg.deps.reduce(go, { [pkg.hash]: pkg.path })