Update AngularFire v7 & Firebase v9 #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@randallmeeker that's a very lazy approach to the upgrade. Using "compat" imports will not give us proper tree-shaking support - the most notable feature of Firebase v9. |
|
@hakimio Please avoid agressive language. @randallmeeker did spend time working on this update, there is nothing lazy about her/his work. Contributing to an open source project is not an easy task and should be supported instead of discouraged. |
|
@GrandSchtroumpf Ok, if no one else is taking this task, I'll look into doing proper upgrade sometime next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I closed #217 and opened this one for simplicity/clarity sake.
resolves #205
@GrandSchtroumpf