Facility to provide interface while registering actors #1350
+199
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Siri Varma Vegiraju <[email protected]>
Signed-off-by: Siri Varma Vegiraju <[email protected]>
Signed-off-by: Siri Varma Vegiraju <[email protected]>
Signed-off-by: Siri Varma Vegiraju <[email protected]>
siri-varma
force-pushed
the
users/svegiraju/pull-request-123
branch
from
004c240
to
c463186
Compare
|
@philliphoff @cgillum Would you folks be able to help with approving the workflows please ? |
3 tasks
|
@siri-varma All in all, I think this looks fine, but I think it'd be helpful to have documentation calling this out as it might be unclear to someone why they're experiencing an exception when implementing an interface that doesn't itself ultimately inherit from an IActor parent. Otherwise, I think all the code looks fine. If you could write up a few words about it in this section, I'd be happy to accept this. |
Signed-off-by: Siri Varma Vegiraju <[email protected]>
|
@WhitWaldo I updated the md file. Let me know if it looks good. Thanks |
WhitWaldo
reviewed
Oct 10, 2024
daprdocs/content/en/dotnet-sdk-docs/dotnet-actors/dotnet-actors-usage.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Siri Varma Vegiraju <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added facility to provide Interface types while registering Actors.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1341
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: