-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Big interpreter rewrite #5406
Draft
StachuDotNet
wants to merge
75
commits into
darklang:main
Choose a base branch
from
StachuDotNet:big-interpreter-rewrite
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Big interpreter rewrite #5406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StachuDotNet
force-pushed
the
big-interpreter-rewrite
branch
3 times, most recently
from
July 31, 2024 19:51
21af1ef
to
8a3496c
Compare
StachuDotNet
force-pushed
the
big-interpreter-rewrite
branch
3 times, most recently
from
August 13, 2024 13:57
4abbe16
to
29faccd
Compare
thoughts on implemented Edit: it worked out (really well!) but might as well keep this around. |
StachuDotNet
force-pushed
the
big-interpreter-rewrite
branch
2 times, most recently
from
August 15, 2024 16:13
2c4303b
to
6ae7196
Compare
StachuDotNet
force-pushed
the
big-interpreter-rewrite
branch
4 times, most recently
from
September 18, 2024 15:07
713821d
to
4299937
Compare
Otherwise, what's the point of all of this
…indUnsafe, and uncomment more tests (2200 passing)
StachuDotNet
commented
Oct 2, 2024
StachuDotNet
commented
Oct 2, 2024
StachuDotNet
force-pushed
the
big-interpreter-rewrite
branch
2 times, most recently
from
October 14, 2024 14:23
71905ce
to
1276835
Compare
StachuDotNet
force-pushed
the
big-interpreter-rewrite
branch
2 times, most recently
from
November 5, 2024 04:32
b19fc85
to
356bb70
Compare
StachuDotNet
force-pushed
the
big-interpreter-rewrite
branch
from
November 5, 2024 04:33
356bb70
to
c4bd61f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big PR that rewrites the Runtime and surrounding bits (esp.
RuntimeTypes
, theInterpreter
, andPT2RT
) to not stack-overflow so trivially (#5222). It should also lay the groundwork for improving overall runtime performance.While working towards that goal, I accidentally handled many other things that have been bugging me for a while.
Here's what's been done towards the stated goal:
RuntimeTypes
no longer has a recursiveExpr
concept, but rather has InstructionsPT2RT
is now notably more complicated, to mapPT.Exprs
(and fns, etc) toRT.Instructions
PT2RT
testsSqlCompiler
andDB.query
have been gutted - I couldn't figure out a way to make them work in this new world, so we'll have to circle back to thatHere's the out-of-scope work that got done:
RuntimeErrors
(RTE
s) are now much better, and always structured --OldStringErrorTODO
is goneBuiltin
s in favor of direct impl in package functions.dark
files[1] so, this closes #5222, closes #5130, closes #5071
There's some follow-up work to be done:
SqlCompiler
andDB.query
RTE
s, generally