You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes#1814 by adding Pubspec.workspace (List<String>?) and Pubspec.resolution (String?). Didn't bump the changelog or version yet because I didn't want to conflict with #1946 (@kevmoo?), but I can do that once it's merged (or rebase this onto that branch).
Does not check that dart: ^3.6.0, leaving that up to these lines in Pub.
An omitted resolution: or workspace field is treated as null.
I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Changes to files need to be accounted for in their respective changelogs.
Coverage ✔️
File
Coverage
pkgs/pubspec_parse/lib/src/pubspec.dart
💚 100 %
This check for test coverage is informational (issues shown here will not fail the PR).
API leaks ✔️
The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
Package
Leaked API symbols
License Headers ✔️
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1814 by adding
Pubspec.workspace
(List<String>?
) andPubspec.resolution
(String?
). Didn't bump the changelog or version yet because I didn't want to conflict with #1946 (@kevmoo?), but I can do that once it's merged (or rebase this onto that branch).Does not check that
dart: ^3.6.0
, leaving that up to these lines in Pub.An omitted
resolution:
orworkspace
field is treated as null.Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.