Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add terminal info to flutter command event #204

Conversation

eliasyishak
Copy link
Contributor

@eliasyishak eliasyishak commented Nov 15, 2023

Related to tracker issue:

Closes:

While migrating the Usage.command static method, includes the commandHasTerminal parameter, I realized that it probably makes sense to include it with the previously migrated CommandResult event.

This new event will now let us record which flutter command was run, while also keeping track of whether the invocation included a terminal.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@eliasyishak
Copy link
Contributor Author

eliasyishak commented Nov 15, 2023

@leighajarett is it actually necessary to have this field as a user property? After looking through flutter code, we are only sending this along with each command event

It looks like the only two fields we send with each event is for the channel and OS, which we are currently doing now
image

int? maxRss,
}) : eventName = DashEvent.flutterCommandResult,
eventData = {
'commandPath': commandPath,
'result': result,
'commandHasTerminal': commandHasTerminal,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The newly added parameter

Copy link
Contributor

@leighajarett leighajarett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eliasyishak eliasyishak merged commit 4649307 into dart-lang:main Nov 15, 2023
6 checks passed
@eliasyishak eliasyishak deleted the add-terminal-info-to-flutter-command-event branch November 15, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants