-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch tests for unified_analytics 5.8.8+2 fixes #281
Patch tests for unified_analytics 5.8.8+2 fixes #281
Conversation
The current plan is to wait and see whether @christopherfujino will be back in action tomorrow, since I don't think we really need (?) to get this published by the end of the week. Once this merges—per https://github.com/dart-lang/tools/pull/280#issuecomment-2189866767—the next step would be to have devoncrew (or someone else with publishing permissions) publish this to pub. |
Can you delete the first |
This is to try to make CI run for this branch.
You want the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@devoncarew the |
This is a follow-up to #280. Basically, that PR cherry-picked some fixes from main (unified_analytics v6) to a new branch meant to eventually be published as unified_analytics v5.8.8+2. However, since there were some API changes in v6, the tests didn't work (I already remembered to verify the tests right after I merged 😛).
This PR patches these tests. It makes
LogHandler::logFile
writable via a@visibleForTestingOnly
setter, which I think is okay for patching an old major version.Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.