Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move clang-format file into root directory #602

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

devreal
Copy link
Member

@devreal devreal commented Oct 30, 2018

This PR will make our .clang-format rules more visible and easier to use (clang-format is looking for that file in the current directory or any parent directory)

@devreal devreal added this to the dash-0.3.0 milestone Oct 30, 2018
@codecov
Copy link

codecov bot commented Oct 30, 2018

Codecov Report

Merging #602 into development will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           development     #602    +/-   ##
=============================================
  Coverage        84.95%   84.95%            
=============================================
  Files              316      316            
  Lines            24159    24159            
  Branches         11513    11109   -404     
=============================================
  Hits             20524    20524            
  Misses            3634     3634            
  Partials             1        1

Copy link
Member

@fmoessbauer fmoessbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another two files in the root directory... For what reason did we have the contrib folder?
@rkowalewski : I guess there was once a discussion to move the dev-only stuff to this folder?

@devreal
Copy link
Member Author

devreal commented Oct 30, 2018

Right now the contrib folder only contains these two files, hidden. For new users (or developers not aware that we have a clang-format stylefile) it's virtually invisible...

@rkowalewski
Copy link

rkowalewski commented Oct 30, 2018

I guess there was once a discussion to move the dev-only stuff to this folder

Yup. The original intent was that we do not want to "pollute" our root directory with files which are not a required part of our toolchain. I am also not aware that everybody uses clang-format. So I used this approach as other projects do it in a similar way. We deleted also the .syntastic_*files for that reason.

But for me it's fine that we move it to the root directory and we should definitely use a common formatting. @pascalj and me are using this one in the repository and it is quite pretty. If you have some suggestion feel free to change it.

@rkowalewski
Copy link

In my opinion we can move some of the build.* files into the contrib folder. The most relevant are build.minimal.sh, build.dev.sh and build.sh. I think almost nobody uses the other files.

@devreal devreal modified the milestones: dash-0.3.0, dash-0.4.0 Nov 1, 2018
@rkowalewski
Copy link

rkowalewski commented Nov 3, 2018

small update to our .clang-format. The settings are based on Google and I just added the relevant customizations for our code base. This way, our config is easier to maintain and gets new features without explicitly adding it in our config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants