Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): add firebase auth to site #19

Conversation

cwadrupldijjit
Copy link
Contributor

What Changed?

  • firebaseHelper.js
    • add helper to manage auth
  • index.jsx
    • create module file to import and export necessary components
  • initializeFirebase.js
    • add file to create the firebase connection
  • gitHubHelpers.js
    • import auth into file to test if it wiill work

Additional Information:

This should be reviewed after #18 since it incorporates those changes in this PR.

Issues Addressed:

no breaking changes; auth not yet fully integrated into the project

Samuel Skeen added 2 commits April 5, 2017 22:55
changes:
  - .babelrc
    - fix quote types to make it conformant JSON
  - .eslintrc
    - update linter to not show errors where errors shouldn't be shown
  - .gitignore
    - begin ignoring the public directory--rely on built code
  - ComposeForm/*
    - beginnings of splitting up FormElements.jsx (will be addressed later)
  - PrefixedLink/index.jsx
    - add component to automatically prefix links in order to avoid having to do it manually
  - gatsby-node.js,
        ComposePage/index.jsx,
        Editor/index.jsx,
        FormElements.jsx,
        GitHubForm.jsx,
        gitHubHelper.js,
        localStorageHelper.js,
        ReadNext/index.jsx,
        SiteLinks/index.jsx,
        SiteNav/index.jsx,
        SitePage/index.jsx,
        SitePost/index.jsx,
        SiteSidebar/index.jsx
    - update files to eslint compliance
    - change repetetive field/element creation into data transformed the way you want
  - public/*
    - remove from git (built)

issues addressed:
  - dashcommunity#14

no breaking changes--UI works exactly as originally implemented
changes:
  - firebaseHelper.js
    - add helper to manage auth
  - index.jsx
    - create module file to import and export necessary components
  - initializeFirebase.js
    - add file to create the firebase connection
  - gitHubHelpers.js
    - import auth into file to test if it wiill work

issues addressed:
  - dashcommunity#15

no breaking changes; auth not yet fully integrated into the project
@riongull riongull closed this May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants