-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding docker to brain-monitor #1
base: master
Are you sure you want to change the base?
Conversation
I get an error called |
I also didn't get a |
OK, there are a couple of issues — you shouldn't be mounting the whole folder under /app because that will also mount any locally installed npm packages under node_modules. When I remove node_modules and stop mounting the volume, I can get to the I don't know what the goal of this development is, though. brain-monitor requires a screen to function — it prints the brainwaves on the screen. It doesn't make much sense to run it inside a docker container. |
The goal is to run your core lib on a docker ( not only brain-monitor), but that also implies that doesn't matter where I'm deploying it, it will deploy well. And you will never get OS problems again. For instance, your readme is for Mac OS only. Brain-monitor sends the data to a console and you can see it inside the docker without any problem. In any case, you can mount devices on a docker. In fact, the headset will be on it as well. About how to mount node modules, it depends. In any case, I'm trying to deploy it without errors first and then get a fine solution. |
The core lib is wits, and it actually works in Docker with your example. brain-monitor requires a tty that has a width, it's not simply a console.log — that's why it doesn't work and you get the error If you replace the contents of const mind = require('wits')
mind.open()
mind.read(console.log) you will see that it will work. |
Also, mounting node_modules doesn't depend on anything, it simply doesn't work. When you do an Say, you have a Mac, you clone the project, and do That's why you can't mount a Mac-compiled |
Its depends, sure that what you are saying is important, because we need to run first on the docker so the installation of npm will compile native C module. But this doesn't make any difference if you later want to install something or checkout something that you have access to. For developing purposes is think is easier for the CI. For the gui is simple to associate. My First initative is with your core lib, and if you are saying that is working, that's great news. In any case, for making brain monitor show a screen could be made as well. This could be one way: http://wiki.ros.org/docker/Tutorials/GUI |
indeed, |
This is throwing an Error Width must be multiple of 2. But I'm not able to create a develop branch and a feature branch so you can test it before merge.
You need to have docker, and docker-compose in order to use those files. With a simple
docker-compose up
should work this first version.