-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dashpay): update submit request UI with backend #1299
Conversation
…ess of username registration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. If the common voting period UI isn't relevant anymore, we can delete it.
@@ -66,7 +66,7 @@ class CreateInviteViewModel @Inject constructor( | |||
private fun combineLatestData(): Boolean { | |||
val isSynced = blockchainStateData.value?.isSynced() ?: false | |||
val noIdentityCreatedOrInProgress = (blockchainIdentity.value == null) || blockchainIdentity.value!!.creationState == BlockchainIdentityData.CreationState.NONE | |||
return isSynced && !noIdentityCreatedOrInProgress && canAffordIdentityCreation() | |||
return isSynced && !noIdentityCreatedOrInProgress //&& canAffordIdentityCreation() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for a canAffordIdentityCreation
check anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We address the canAffordIdentityCreation in other places in the UI.
I will remove this commented code.
Issue being fixed or feature implemented
Related PR's and Dependencies
dashpay/kotlin-platform#9
dashpay/dashj#259
HashEngineering/platform-mobile#3
Screenshots / Videos
How Has This Been Tested?
Checklist: