Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashpay): update submit request UI with backend #1299

Merged
merged 21 commits into from
Aug 28, 2024

Conversation

HashEngineering
Copy link
Collaborator

@HashEngineering HashEngineering commented Aug 19, 2024

Issue being fixed or feature implemented

Related PR's and Dependencies

dashpay/kotlin-platform#9
dashpay/dashj#259
HashEngineering/platform-mobile#3

Screenshots / Videos

How Has This Been Tested?

  • QA (Mobile Team)

Checklist:

  • I have performed a self-review of my own code and added comments where necessary
  • I have added or updated relevant unit/integration/functional/e2e tests

Copy link
Member

@Syn-McJ Syn-McJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. If the common voting period UI isn't relevant anymore, we can delete it.

@@ -66,7 +66,7 @@ class CreateInviteViewModel @Inject constructor(
private fun combineLatestData(): Boolean {
val isSynced = blockchainStateData.value?.isSynced() ?: false
val noIdentityCreatedOrInProgress = (blockchainIdentity.value == null) || blockchainIdentity.value!!.creationState == BlockchainIdentityData.CreationState.NONE
return isSynced && !noIdentityCreatedOrInProgress && canAffordIdentityCreation()
return isSynced && !noIdentityCreatedOrInProgress //&& canAffordIdentityCreation()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for a canAffordIdentityCreation check anymore?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We address the canAffordIdentityCreation in other places in the UI.

I will remove this commented code.

@HashEngineering HashEngineering marked this pull request as ready for review August 28, 2024 13:33
@HashEngineering HashEngineering merged commit 66c4816 into dashpay Aug 28, 2024
1 check failed
@HashEngineering HashEngineering deleted the dashpay-feature-submit-request branch October 8, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants