Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: create DualBlockChain class to handle header and regular ch… #231

Merged
merged 3 commits into from
Sep 26, 2023

Conversation

HashEngineering
Copy link
Collaborator

@HashEngineering HashEngineering commented Sep 19, 2023

…ain objects

Issue being fixed or feature implemented

What was done?

Refactor how blockchain objects are handled for masternode lists and quorums

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@HashEngineering HashEngineering self-assigned this Sep 19, 2023
* update AuthenticationKeyChainGroupTest

Signed-off-by: HashEngineering <[email protected]>
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Patch coverage: 62.55% and project coverage change: +0.17% 🎉

Comparison is base (01c4e3c) 47.50% compared to head (c3ff717) 47.67%.

Additional details and impacted files
@@                      Coverage Diff                      @@
##             feature-core-20-phase-1     #231      +/-   ##
=============================================================
+ Coverage                      47.50%   47.67%   +0.17%     
- Complexity                      6580     6615      +35     
=============================================================
  Files                            408      409       +1     
  Lines                          46144    46113      -31     
  Branches                        6518     6503      -15     
=============================================================
+ Hits                           21919    21983      +64     
+ Misses                         21843    21757      -86     
+ Partials                        2382     2373       -9     
Files Changed Coverage Δ
.../org/bitcoinj/evolution/AbstractQuorumRequest.java 66.66% <ø> (ø)
...inj/evolution/GetSimplifiedMasternodeListDiff.java 25.00% <0.00%> (+1.66%) ⬆️
...va/org/bitcoinj/evolution/QuorumUpdateRequest.java 47.05% <ø> (ø)
...va/org/bitcoinj/quorums/GetQuorumRotationInfo.java 20.58% <0.00%> (+1.14%) ⬆️
...va/org/bitcoinj/evolution/AbstractQuorumState.java 34.59% <11.11%> (-0.16%) ⬇️
...inj/evolution/SimplifiedMasternodeListManager.java 49.06% <52.63%> (+1.92%) ⬆️
...rc/main/java/org/bitcoinj/core/DualBlockChain.java 56.75% <56.75%> (ø)
...ava/org/bitcoinj/quorums/SimplifiedQuorumList.java 54.02% <66.66%> (-0.18%) ⬇️
...va/org/bitcoinj/evolution/QuorumRotationState.java 61.38% <67.64%> (+1.56%) ⬆️
.../main/java/org/bitcoinj/evolution/QuorumState.java 54.21% <80.00%> (+0.14%) ⬆️
... and 6 more

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HashEngineering HashEngineering marked this pull request as ready for review September 25, 2023 17:17
Copy link
Member

@Syn-McJ Syn-McJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@HashEngineering HashEngineering changed the base branch from feature-core-20-phase-1 to feature-core-20 September 26, 2023 15:45
@HashEngineering HashEngineering merged commit b4a4f7c into feature-core-20 Sep 26, 2023
6 checks passed
@HashEngineering HashEngineering deleted the feature-core-20-refactor-blockchain branch October 30, 2023 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants