Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(voting): enter username #626

Merged
merged 3 commits into from
Nov 24, 2023
Merged

feat(voting): enter username #626

merged 3 commits into from
Nov 24, 2023

Conversation

Syn-McJ
Copy link
Member

@Syn-McJ Syn-McJ commented Nov 23, 2023

Issue being fixed or feature implemented

After going through "Join DashPay" and first-time info, the user should be able to enter their username request.

What was done?

  • UI for entering a username request.
  • Refactor DWDateFormatter to Swift.

How Has This Been Tested?

QA

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@Syn-McJ Syn-McJ requested a review from pankcuf November 23, 2023 04:28
@Syn-McJ Syn-McJ self-assigned this Nov 23, 2023
pankcuf
pankcuf approved these changes Nov 24, 2023
View reviewed changes
Copy link
Collaborator

@pankcuf pankcuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Syn-McJ Syn-McJ merged commit f254155 into dashpay:develop Nov 24, 2023
1 check passed
@Syn-McJ Syn-McJ deleted the feat/request-username-enter branch November 24, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pankcuf pankcuf pankcuf approved these changes

Assignees

@Syn-McJ Syn-McJ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Syn-McJ @pankcuf