Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: QR isn't recognized #629

Merged
merged 2 commits into from
Dec 5, 2023
Merged

fix: QR isn't recognized #629

merged 2 commits into from
Dec 5, 2023

Conversation

Syn-McJ
Copy link
Member

@Syn-McJ Syn-McJ commented Nov 30, 2023

Issue being fixed or feature implemented

On small screens (SE) users have trouble recognizing QR code because the logo is too large.

What was done?

  • Set the logo size at 22% regardless of QR or screen size.
  • Increase QR quality for better redundancy.

How Has This Been Tested?

QA

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@Syn-McJ Syn-McJ requested a review from pankcuf November 30, 2023 07:25
@Syn-McJ Syn-McJ self-assigned this Nov 30, 2023
pankcuf
pankcuf approved these changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@pankcuf pankcuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Syn-McJ Syn-McJ merged commit 3a97d65 into dashpay:develop Dec 5, 2023
1 check passed
@Syn-McJ Syn-McJ deleted the fix/large-qr-logo branch December 5, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pankcuf pankcuf pankcuf approved these changes

Assignees

@Syn-McJ Syn-McJ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Syn-McJ @pankcuf