Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(voting): cancel username request #631

Merged
merged 14 commits into from
Dec 5, 2023

Conversation

Syn-McJ
Copy link
Member

@Syn-McJ Syn-McJ commented Nov 30, 2023

Issue being fixed or feature implemented

Cancelling logic was mostly done in other PRs, however, a couple of thigs remain:

  • Subsequent requests should not require payment.
  • The more menu should display requested username and voting period.

What was done?

  • Cancelling logic improved.
  • UI for the requested username in More menu.
  • Convert DWShadowView to Swift
  • Convert DWDPWelcomeMenuView to Swift

How Has This Been Tested?

QA

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@Syn-McJ Syn-McJ requested a review from pankcuf November 30, 2023 12:57
@Syn-McJ Syn-McJ self-assigned this Nov 30, 2023
Copy link
Collaborator

@pankcuf pankcuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Syn-McJ Syn-McJ merged commit deb5fbd into dashpay:develop Dec 5, 2023
1 check passed
@Syn-McJ Syn-McJ deleted the feat/cancel-username-request branch December 5, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants