fix(explore-dash): sorting options for All category #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syn-McJ
commented
Jan 22, 2024
|
|
||
| @objc | ||
| func enteredBackround() { | ||
| dismiss(animated: false) |
There was a problem hiding this comment.
Dismiss the filter dialog if the user switches from the app as they might be in the settings to change the location permission. The filters will be refreshed on re-open.
Dynamic view update might be better here, but more complicated.
Syn-McJ
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
In the All category, the app shows "A-Z / Z-A" sorting options while it should be "by name / by distance", and hidden if the location services are off.
What was done?
How Has This Been Tested?
QA
Breaking Changes
Checklist:
For repository code-owners and collaborators only