Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(usernames): mix dash warning #670

Merged
merged 7 commits into from
Oct 21, 2024

Conversation

Syn-McJ
Copy link
Member

@Syn-McJ Syn-McJ commented Oct 17, 2024

Issue being fixed or feature implemented

We want to warn the user that their balance should be mixed before creating a username.

What was done?

  • Converted a bunch of username flow screens from Obj-C to Swift
  • Added a "Mix your dash" bottom sheet dialog
  • Show the dialog on the Home screen, Main Menu, and Contacts screen

How Has This Been Tested?

QA

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@Syn-McJ Syn-McJ requested a review from pankcuf October 17, 2024 13:24
@Syn-McJ Syn-McJ self-assigned this Oct 17, 2024
Copy link
Collaborator

@pankcuf pankcuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Syn-McJ Syn-McJ merged commit 2205480 into dashpay:feat/coinjoin Oct 21, 2024
1 check failed
@Syn-McJ Syn-McJ deleted the feat/usernames-mixing-warning branch October 21, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants