feat(platform)!: matched withdrawal fees to actual processing cost (#… #3955
Annotations
12 warnings
Setup Rust
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
The following actions use a deprecated Node.js version and will be forced to run on node20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Run clechasseur/rs-clippy-check@v3:
packages/rs-platform-serialization-derive/src/attribute.rs#L8
warning: field `unversioned` is never read
--> packages/rs-platform-serialization-derive/src/attribute.rs:8:9
|
5 | pub struct ContainerAttributes {
| ------------------- field in this struct
...
8 | pub unversioned: bool,
| ^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
Run clechasseur/rs-clippy-check@v3:
packages/rs-platform-serialization-derive/src/attribute.rs#L114
warning: field `platform_version_path_bounds` is never read
--> packages/rs-platform-serialization-derive/src/attribute.rs:114:9
|
111 | pub struct FieldAttributes {
| --------------- field in this struct
...
114 | pub platform_version_path_bounds: String,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
Run clechasseur/rs-clippy-check@v3:
packages/rs-dpp/src/state_transition/mod.rs#L155
warning: unused variable: `st`
--> packages/rs-dpp/src/state_transition/mod.rs:155:45
|
155 | StateTransition::IdentityCreate(st) => None,
| ^^ help: if this is intentional, prefix it with an underscore: `_st`
...
404 | call_getter_method_identity_signed!(self, security_level_requirement, purpose)
| ------------------------------------------------------------------------------ in this macro invocation
|
= note: `#[warn(unused_variables)]` on by default
= note: this warning originates in the macro `call_getter_method_identity_signed` (in Nightly builds, run with -Z macro-backtrace for more info)
|
Run clechasseur/rs-clippy-check@v3:
packages/rs-dpp/src/state_transition/mod.rs#L156
warning: unused variable: `st`
--> packages/rs-dpp/src/state_transition/mod.rs:156:44
|
156 | StateTransition::IdentityTopUp(st) => None,
| ^^ help: if this is intentional, prefix it with an underscore: `_st`
...
404 | call_getter_method_identity_signed!(self, security_level_requirement, purpose)
| ------------------------------------------------------------------------------ in this macro invocation
|
= note: this warning originates in the macro `call_getter_method_identity_signed` (in Nightly builds, run with -Z macro-backtrace for more info)
|
Run clechasseur/rs-clippy-check@v3:
packages/rs-drive/src/util/batch/drive_op_batch/withdrawals.rs#L4
warning: unused imports: `get_withdrawal_transactions_broadcasted_path` and `get_withdrawal_transactions_queue_path`
--> packages/rs-drive/src/util/batch/drive_op_batch/withdrawals.rs:4:35
|
4 | get_withdrawal_root_path_vec, get_withdrawal_transactions_broadcasted_path,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
5 | get_withdrawal_transactions_broadcasted_path_vec, get_withdrawal_transactions_queue_path,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
Run clechasseur/rs-clippy-check@v3:
packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_masternode_identities/update_operator_identity/v0/mod.rs#L268
warning: this `else { if .. }` block can be collapsed
--> packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_masternode_identities/update_operator_identity/v0/mod.rs:268:24
|
268 | } else {
| ________________________^
269 | | if let Some((_, found_old_key)) = identity_to_enable_old_keys
270 | | .iter()
271 | | .find(|(_, key)| key.purpose() == Purpose::TRANSFER)
... |
282 | | }
283 | | };
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if
= note: `#[warn(clippy::collapsible_else_if)]` on by default
help: collapse nested if block
|
268 ~ } else if let Some((_, found_old_key)) = identity_to_enable_old_keys
269 + .iter()
270 + .find(|(_, key)| key.purpose() == Purpose::TRANSFER)
271 + {
272 + Some(found_old_key.data().to_vec().try_into().map_err(|_| {
273 + Error::Execution(ExecutionError::CorruptedDriveResponse(
274 + "old payout address should be 20 bytes".to_string(),
275 + ))
276 + })?)
277 + } else {
278 + // finally we just use the old masternode payout address
279 + // we need to use the old pub_key_operator
280 + old_masternode.state.operator_payout_address
281 ~ };
|
|
Run clechasseur/rs-clippy-check@v3:
packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_masternode_identities/update_operator_identity/v0/mod.rs#L323
warning: taken reference of right operand
--> packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_masternode_identities/update_operator_identity/v0/mod.rs:323:42
|
323 | .find(|(_, key)| key.data().as_slice() == &new_payout_address)
| ^^^^^^^^^^^^^^^^^^^^^^^^^-------------------
| |
| help: use the right value directly: `new_payout_address`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
= note: `#[warn(clippy::op_ref)]` on by default
|
Run clechasseur/rs-clippy-check@v3:
packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_masternode_identities/update_operator_identity/v0/mod.rs#L347
warning: taken reference of right operand
--> packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_masternode_identities/update_operator_identity/v0/mod.rs:347:42
|
347 | .find(|(_, key)| key.data().as_slice() == &new_platform_node_id)
| ^^^^^^^^^^^^^^^^^^^^^^^^^---------------------
| |
| help: use the right value directly: `new_platform_node_id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
|
Run clechasseur/rs-clippy-check@v3:
packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/identity_credit_withdrawal/balance/v0/mod.rs#L8
warning: unused import: `crate::execution::types::execution_operation::ValidationOperation`
--> packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/identity_credit_withdrawal/balance/v0/mod.rs:8:5
|
8 | use crate::execution::types::execution_operation::ValidationOperation;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
Run clechasseur/rs-clippy-check@v3:
packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/identity_credit_withdrawal/balance/v0/mod.rs#L10
warning: unused imports: `StateTransitionExecutionContextMethodsV0` and `StateTransitionExecutionContext`
--> packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/identity_credit_withdrawal/balance/v0/mod.rs:10:5
|
10 | StateTransitionExecutionContext, StateTransitionExecutionContextMethodsV0,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
Loading