warning: unused import: `crate::util::type_constants::DEFAULT_HASH_SIZE_U8` --> packages/rs-drive/src/drive/document/paths.rs:2:5 | 2 | use crate::util::type_constants::DEFAULT_HASH_SIZE_U8; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default

unused import: `dpp::data_contract::document_type::accessors::DocumentTypeV0Getters`: packages/rs-drive/src/drive/document/paths.rs#L3

warning: unused import: `dpp::data_contract::document_type::accessors::DocumentTypeV0Getters` --> packages/rs-drive/src/drive/document/paths.rs:3:5 | 3 | use dpp::data_contract::document_type::accessors::DocumentTypeV0Getters; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

unused import: `dpp::data_contract::document_type::methods::DocumentTypeV0Methods`: packages/rs-drive/src/drive/document/paths.rs#L4

warning: unused import: `dpp::data_contract::document_type::methods::DocumentTypeV0Methods` --> packages/rs-drive/src/drive/document/paths.rs:4:5 | 4 | use dpp::data_contract::document_type::methods::DocumentTypeV0Methods; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

unused import: `dpp::data_contract::document_type::DocumentTypeRef`: packages/rs-drive/src/drive/document/paths.rs#L5

warning: unused import: `dpp::data_contract::document_type::DocumentTypeRef` --> packages/rs-drive/src/drive/document/paths.rs:5:5 | 5 | use dpp::data_contract::document_type::DocumentTypeRef; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

function `contract_documents_primary_key_path` is never used: packages/rs-drive/src/drive/document/paths.rs#L41

warning: function `contract_documents_primary_key_path` is never used --> packages/rs-drive/src/drive/document/paths.rs:41:15 | 41 | pub(crate) fn contract_documents_primary_key_path<'a>( | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

unused import: `identity::identity_public_key::accessors::v0::IdentityPublicKeyGettersV0`: packages/rs-drive/src/drive/identity/key/fetch/mod.rs#L16

warning: unused import: `identity::identity_public_key::accessors::v0::IdentityPublicKeyGettersV0` --> packages/rs-drive/src/drive/identity/key/fetch/mod.rs:16:9 | 16 | identity::identity_public_key::accessors::v0::IdentityPublicKeyGettersV0, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

unused import: `crate::drive::votes::resolved::vote_polls::contested_document_resource_vote_poll::ContestedDocumentResourceVotePollWithContractInfo`: packages/rs-drive/src/drive/votes/resolved/vote_polls/contested_document_resource_vote_poll/resolve.rs#L3

warning: unused import: `crate::drive::votes::resolved::vote_polls::contested_document_resource_vote_poll::ContestedDocumentResourceVotePollWithContractInfo` --> packages/rs-drive/src/drive/votes/resolved/vote_polls/contested_document_resource_vote_poll/resolve.rs:3:5 | 3 | use crate::drive::votes::resolved::vote_polls::contested_document_resource_vote_poll::ContestedDocumentResourceVotePollWithContractInfo; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

unused import: `crate::drive::Drive`: packages/rs-drive/src/drive/votes/resolved/vote_polls/contested_document_resource_vote_poll/resolve.rs#L6

warning: unused import: `crate::drive::Drive` --> packages/rs-drive/src/drive/votes/resolved/vote_polls/contested_document_resource_vote_poll/resolve.rs:6:5 | 6 | use crate::drive::Drive; | ^^^^^^^^^^^^^^^^^^^

unused import: `crate::util::object_size_info::DataContractOwnedResolvedInfo`: packages/rs-drive/src/drive/votes/resolved/vote_polls/contested_document_resource_vote_poll/resolve.rs#L11

warning: unused import: `crate::util::object_size_info::DataContractOwnedResolvedInfo` --> packages/rs-drive/src/drive/votes/resolved/vote_polls/contested_document_resource_vote_poll/resolve.rs:11:5 | 11 | use crate::util::object_size_info::DataContractOwnedResolvedInfo; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

unused import: `platform_version::version::PlatformVersion`: packages/rs-drive/src/drive/votes/resolved/vote_polls/contested_document_resource_vote_poll/resolve.rs#L20

warning: unused import: `platform_version::version::PlatformVersion` --> packages/rs-drive/src/drive/votes/resolved/vote_polls/contested_document_resource_vote_poll/resolve.rs:20:5 | 20 | use platform_version::version::PlatformVersion; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Rust packages (drive) / Formatting

Rust packages (dpp) / Unused dependencies

Rust packages (drive-abci) / Formatting

Rust packages (dpp) / Tests

Rust packages (dash-sdk) / Tests

Rust packages (dpp) / Linting

taken reference of right operand: packages/rs-dpp/src/data_contract/document_type/property/mod.rs#L1203

warning: taken reference of right operand --> packages/rs-dpp/src/data_contract/document_type/property/mod.rs:1203:20 | 1203 | if value == &vec![0] { | ^^^^^^^^^-------- | | | help: use the right value directly: `...` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref = note: `#[warn(clippy::op_ref)]` on by default

taken reference of right operand: packages/rs-dpp/src/data_contract/document_type/property/mod.rs#L1294

warning: taken reference of right operand --> packages/rs-dpp/src/data_contract/document_type/property/mod.rs:1294:20 | 1294 | if value == &vec![0] { | ^^^^^^^^^-------- | | | help: use the right value directly: `...` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref

taken reference of right operand: packages/rs-dpp/src/data_contract/document_type/property/mod.rs#L1296

warning: taken reference of right operand --> packages/rs-dpp/src/data_contract/document_type/property/mod.rs:1296:27 | 1296 | } else if value == &vec![1] { | ^^^^^^^^^-------- | | | help: use the right value directly: `...` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref

non-canonical implementation of `partial_cmp` on an `Ord` type: packages/rs-dpp/src/data_contract/document_type/index/mod.rs#L157

warning: non-canonical implementation of `partial_cmp` on an `Ord` type --> packages/rs-dpp/src/data_contract/document_type/index/mod.rs:157:1 | 157 | / impl PartialOrd for ContestedIndexFieldMatch { 158 | | fn partial_cmp(&self, other: &Self) -> Option<Ordering> { | | _____________________________________________________________- 159 | || use ContestedIndexFieldMatch::*; 160 | || match (self, other) { 161 | || // Comparing two integers ... || 170 | || } 171 | || } | ||_____- help: change this to: `{ Some(self.cmp(other)) }` 172 | | } | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default

`to_string` applied to a type that implements `Display` in `format!` args: packages/rs-dpp/src/data_contract/document_type/index/mod.rs#L503

warning: `to_string` applied to a type that implements `Display` in `format!` args --> packages/rs-dpp/src/data_contract/document_type/index/mod.rs:503:66 | 503 | ... e.to_string() | ^^^^^^^^^^^^ help: remove this | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args = note: `#[warn(clippy::to_string_in_format_args)]` on by default

iterating on a map's values: packages/rs-dpp/src/data_contract/document_type/v0/random_document_type.rs#L396

warning: iterating on a map's values --> packages/rs-dpp/src/data_contract/document_type/v0/random_document_type.rs:396:35 | 396 | let indices_json_schema = indices | ___________________________________^ 397 | | .iter() 398 | | .map(|(_, index)| { 399 | | let properties_schema = index ... | 412 | | }) 413 | | }) | |______________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map = note: `#[warn(clippy::iter_kv_map)]` on by default help: try | 396 ~ let indices_json_schema = indices.values().map(|index| { 397 + let properties_schema = index 398 + .properties 399 + .iter() 400 + .map(|prop| { 401 + // Only "asc" is allowed for now (v1.0-dev) 402 + json!({ <std::string::String as Clone>::clone(&prop.name): "asc" }) 403 + }) 404 + .collect::<Vec<_>>(); 405 + 406 + json!({ 407 + "name": index.name, 408 + "properties": properties_schema, 409 + "unique": index.unique, 410 + }) 411 + }) |

unnecessary use of `get(name).is_some()`: packages/rs-dpp/src/data_contract/v0/accessors/mod.rs#L70

warning: unnecessary use of `get(name).is_some()` --> packages/rs-dpp/src/data_contract/v0/accessors/mod.rs:70:29 | 70 | self.document_types.get(name).is_some() | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(name)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default

very complex type used. Consider factoring parts into `type` definitions: packages/rs-dpp/src/document/document_factory/v0/mod.rs#L215

warning: very complex type used. Consider factoring parts into `type` definitions --> packages/rs-dpp/src/document/document_factory/v0/mod.rs:215:24 | 215 | let documents: Vec<( | ________________________^ 216 | | DocumentTransitionActionType, 217 | | Vec<(Document, DocumentTypeRef, Bytes32)>, 218 | | )> = documents_iter.into_iter().collect(); | |__________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default

writing `&Vec` instead of `&[_]` involves a new object where a slice will do: packages/rs-dpp/src/document/document_methods/is_equal_ignoring_timestamps/v0/mod.rs#L23

warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do --> packages/rs-dpp/src/document/document_methods/is_equal_ignoring_timestamps/v0/mod.rs:23:28 | 23 | ignore_fields: &Vec<&str>, | ^^^^^^^^^^ help: change this to: `&[&str]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `#[warn(clippy::ptr_arg)]` on by default

very complex type used. Consider factoring parts into `type` definitions: packages/rs-dpp/src/document/specialized_document_factory/v0/mod.rs#L223

warning: very complex type used. Consider factoring parts into `type` definitions --> packages/rs-dpp/src/document/specialized_document_factory/v0/mod.rs:223:24 | 223 | let documents: Vec<( | ________________________^ 224 | | DocumentTransitionActionType, 225 | | Vec<(Document, DocumentTypeRef, Bytes32)>, 226 | | )> = documents_iter.into_iter().collect(); | |__________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity

Rust packages (dash-sdk) / Check each feature

Rust packages (wasm-dpp) / Formatting

Rust packages (drive) / Unused dependencies

Rust packages (drive) / Linting

unused import: `platform_value::Identifier`: packages/rs-dpp/src/state_transition/state_transitions/identity/identity_credit_transfer_transition/v0/v0_methods.rs#L11

warning: unused import: `platform_value::Identifier` --> packages/rs-dpp/src/state_transition/state_transitions/identity/identity_credit_transfer_transition/v0/v0_methods.rs:11:5 | 11 | use platform_value::Identifier; | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default

unused import: `crate::state_transition::GetDataContractSecurityLevelRequirementFn`: packages/rs-dpp/src/state_transition/state_transitions/identity/identity_credit_transfer_transition/v0/v0_methods.rs#L15

warning: unused import: `crate::state_transition::GetDataContractSecurityLevelRequirementFn` --> packages/rs-dpp/src/state_transition/state_transitions/identity/identity_credit_transfer_transition/v0/v0_methods.rs:15:5 | 15 | use crate::state_transition::GetDataContractSecurityLevelRequirementFn; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

this `else { if .. }` block can be collapsed: packages/rs-drive/src/query/mod.rs#L1301

warning: this `else { if .. }` block can be collapsed --> packages/rs-drive/src/query/mod.rs:1301:16 | 1301 | } else { | ________________^ 1302 | | if let Some(start_at_key) = start_at_key { 1303 | | inner_query.insert_range_to(..start_at_key); 1304 | | } else { ... | 1308 | | } 1309 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if = note: `#[warn(clippy::collapsible_else_if)]` on by default help: collapse nested if block | 1301 ~ } else if let Some(start_at_key) = start_at_key { 1302 + inner_query.insert_range_to(..start_at_key); 1303 + } else { 1304 + //todo: really not sure if this is correct 1305 + // Should investigate more 1306 + inner_query.insert_key(vec![]); 1307 + } |

unnecessary use of `get(field.name.as_str()) .is_some()`: packages/rs-drive/src/query/mod.rs#L1532

warning: unnecessary use of `get(field.name.as_str()) .is_some()` --> packages/rs-drive/src/query/mod.rs:1532:22 | 1532 | .get(field.name.as_str()) | ______________________^ 1533 | | .is_some() | |______________________________^ help: replace it with: `contains_key(field.name.as_str())` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default

doc list item missing indentation: packages/rs-drive/src/drive/contract/get_fetch/fetch_contract_with_history/v0/mod.rs#L26

warning: doc list item missing indentation --> packages/rs-drive/src/drive/contract/get_fetch/fetch_contract_with_history/v0/mod.rs:26:9 | 26 | /// start fetching the contract's history. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation = note: `#[warn(clippy::doc_lazy_continuation)]` on by default help: indent this line | 26 | /// start fetching the contract's history. | ++

doc list item missing indentation: packages/rs-drive/src/drive/contract/get_fetch/fetch_contract_with_history/v0/mod.rs#L29

warning: doc list item missing indentation --> packages/rs-drive/src/drive/contract/get_fetch/fetch_contract_with_history/v0/mod.rs:29:9 | 29 | /// to return. If `None`, the limit is set to 10. Should be between 1 and 10. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 29 | /// to return. If `None`, the limit is set to 10. Should be between 1 and 10. | ++

doc list item missing indentation: packages/rs-drive/src/drive/contract/get_fetch/fetch_contract_with_history/v0/mod.rs#L32

warning: doc list item missing indentation --> packages/rs-drive/src/drive/contract/get_fetch/fetch_contract_with_history/v0/mod.rs:32:9 | 32 | /// before starting to return them. If `None`, no entries are skipped. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 32 | /// before starting to return them. If `None`, no entries are skipped. | ++

doc list item missing indentation: packages/rs-drive/src/drive/contract/get_fetch/fetch_contract_with_history/v0/mod.rs#L37

warning: doc list item missing indentation --> packages/rs-drive/src/drive/contract/get_fetch/fetch_contract_with_history/v0/mod.rs:37:9 | 37 | /// a `BTreeMap` with Unix timestamp as the key and contract as the value, representing | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 37 | /// a `BTreeMap` with Unix timestamp as the key and contract as the value, representing | ++

doc list item missing indentation: packages/rs-drive/src/drive/contract/get_fetch/fetch_contract_with_history/v0/mod.rs#L38

warning: doc list item missing indentation --> packages/rs-drive/src/drive/contract/get_fetch/fetch_contract_with_history/v0/mod.rs:38:9 | 38 | /// the contract's history. The `Err` variant contains an `Error` in case of a failure. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 38 | /// the contract's history. The `Err` variant contains an `Error` in case of a failure. | ++

doc list item missing indentation: packages/rs-drive/src/drive/contract/get_fetch/fetch_contract_with_history/v0/mod.rs#L45

warning: doc list item missing indentation --> packages/rs-drive/src/drive/contract/get_fetch/fetch_contract_with_history/v0/mod.rs:45:9 | 45 | /// contract history. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 45 | /// contract history. | ++

Rust packages (dpp) / Check each feature

Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image

Input 'config-inline' has been deprecated with message: Use buildkitd-config-inline instead

Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image

Input 'config-inline' has been deprecated with message: Use buildkitd-config-inline instead

Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/github-script@v6. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Rust packages (wasm-dpp) / Unused dependencies

JS packages (@dashevo/dapi) / Linting

JS packages (@dashevo/dapi-client) / Linting

JS packages (@dashevo/dapi-client) / Linting: packages/js-dapi-client/lib/BlockHeadersProvider/BlockHeadersProvider.js#L8

Missing JSDoc @Property "network" description

JS packages (@dashevo/dapi-client) / Linting: packages/js-dapi-client/lib/BlockHeadersProvider/BlockHeadersProvider.js#L38

Missing JSDoc @param "options" description

JS packages (@dashevo/dapi-client) / Linting: packages/js-dapi-client/lib/BlockHeadersProvider/BlockHeadersProvider.js#L39

Missing JSDoc @param "createHistoricalSyncStream" description

JS packages (@dashevo/dapi-client) / Linting: packages/js-dapi-client/lib/BlockHeadersProvider/BlockHeadersProvider.js#L40

Missing JSDoc @param "createContinuousSyncStream" description

JS packages (@dashevo/dapi-client) / Linting: packages/js-dapi-client/lib/BlockHeadersProvider/BlockHeadersProvider.js#L63

Missing JSDoc @param "blockHeadersReader" description

JS packages (@dashevo/dapi-client) / Linting: packages/js-dapi-client/lib/BlockHeadersProvider/BlockHeadersProvider.js#L71

Missing JSDoc @param "spvChain" description

JS packages (@dashevo/dapi-client) / Linting: packages/js-dapi-client/lib/BlockHeadersProvider/BlockHeadersProvider.js#L107

Missing JSDoc @param "headers" description

JS packages (@dashevo/dapi-client) / Linting: packages/js-dapi-client/lib/BlockHeadersProvider/BlockHeadersProvider.js#L107

Missing JSDoc @param "headers" type

JS packages (@dashevo/dapi-client) / Linting: packages/js-dapi-client/lib/BlockHeadersProvider/BlockHeadersProvider.js#L108

Missing JSDoc @param "firstHeaderHeight" description

JS packages (@dashevo/dapi-client) / Linting: packages/js-dapi-client/lib/BlockHeadersProvider/BlockHeadersProvider.js#L108

Missing JSDoc @param "firstHeaderHeight" type

Build Docker images (DAPI, dapi, dapi) / Build DAPI image

Input 'config-inline' has been deprecated with message: Use buildkitd-config-inline instead

Build Docker images (DAPI, dapi, dapi) / Build DAPI image

Input 'config-inline' has been deprecated with message: Use buildkitd-config-inline instead

Build Docker images (DAPI, dapi, dapi) / Build DAPI image

Rust packages (drive-abci) / Unused dependencies

Rust packages (wasm-dpp) / Linting

bound is defined in more than one place: packages/wasm-dpp/src/utils.rs#L25

warning: bound is defined in more than one place --> packages/wasm-dpp/src/utils.rs:25:24 | 25 | fn with_serde_into<D: DeserializeOwned>(&self) -> Result<D, JsValue> | ^ 26 | where 27 | D: for<'de> serde::de::Deserialize<'de> + 'static; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations = note: `#[warn(clippy::multiple_bound_locations)]` on by default

methods `with_serde_to_platform_value_map` and `with_serde_into` are never used: packages/wasm-dpp/src/utils.rs#L24

warning: methods `with_serde_to_platform_value_map` and `with_serde_into` are never used --> packages/wasm-dpp/src/utils.rs:24:8 | 19 | pub trait ToSerdeJSONExt { | -------------- methods in this trait ... 24 | fn with_serde_to_platform_value_map(&self) -> Result<BTreeMap<String, Value>, JsValue>; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 25 | fn with_serde_into<D: DeserializeOwned>(&self) -> Result<D, JsValue> | ^^^^^^^^^^^^^^^

methods `into_inner` and `inner_mut` are never used: packages/wasm-dpp/src/utils.rs#L287

warning: methods `into_inner` and `inner_mut` are never used --> packages/wasm-dpp/src/utils.rs:287:8 | 284 | pub(crate) trait Inner { | ----- methods in this trait ... 287 | fn into_inner(self) -> Self::InnerItem; | ^^^^^^^^^^ 288 | fn inner(&self) -> &Self::InnerItem; 289 | fn inner_mut(&mut self) -> &mut Self::InnerItem; | ^^^^^^^^^

field `0` is never read: packages/wasm-dpp/src/identity/identity_facade.rs#L274

warning: field `0` is never read --> packages/wasm-dpp/src/identity/identity_facade.rs:274:34 | 274 | pub struct NonConsensusErrorWasm(NonConsensusError); | --------------------- ^^^^^^^^^^^^^^^^^ | | | field in this struct | = note: `#[warn(dead_code)]` on by default help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 274 | pub struct NonConsensusErrorWasm(()); | ~~

trait `AssetLockProofLike` is never used: packages/wasm-dpp/src/identity/state_transition/asset_lock_proof/mod.rs#L49

warning: trait `AssetLockProofLike` is never used --> packages/wasm-dpp/src/identity/state_transition/asset_lock_proof/mod.rs:49:11 | 49 | pub trait AssetLockProofLike { | ^^^^^^^^^^^^^^^^^^

field `identity_id` is never read: packages/wasm-dpp/src/identity/state_transition/identity_create_transition/to_object.rs#L21

warning: field `identity_id` is never read --> packages/wasm-dpp/src/identity/state_transition/identity_create_transition/to_object.rs:21:9 | 19 | pub struct ToObject { | -------- field in this struct 20 | pub transition_type: u8, 21 | pub identity_id: Identifier, | ^^^^^^^^^^^

field `vote` is never read: packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/to_object.rs#L21

warning: field `vote` is never read --> packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/to_object.rs:21:9 | 18 | pub struct ToObject { | -------- field in this struct ... 21 | pub vote: Vote, | ^^^^

module has the same name as its containing module: packages/wasm-dpp/src/data_contract_factory/mod.rs#L1

warning: module has the same name as its containing module --> packages/wasm-dpp/src/data_contract_factory/mod.rs:1:1 | 1 | mod data_contract_factory; | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception = note: `#[warn(clippy::module_inception)]` on by default

very complex type used. Consider factoring parts into `type` definitions: packages/wasm-dpp/src/document/factory.rs#L153

warning: very complex type used. Consider factoring parts into `type` definitions --> packages/wasm-dpp/src/document/factory.rs:153:24 | 153 | let documents: Vec<( | ________________________^ 154 | | DocumentTransitionActionType, 155 | | Vec<(Document, DocumentTypeRef, Bytes32)>, 156 | | )> = documents_by_action | |__________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default

use of a fallible conversion when an infallible one could be used: packages/wasm-dpp/src/document/factory.rs#L322

warning: use of a fallible conversion when an infallible one could be used --> packages/wasm-dpp/src/document/factory.rs:322:27 | 322 | let documents_array = js_sys::Array::try_from(documents_with_action) | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `From::from` | = note: converting `JsValue` to `Array` cannot fail = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default

JS packages (@dashevo/dapi) / Tests

Rust packages (wasm-dpp) / Tests

JS packages (@dashevo/wallet-lib) / Linting

JS packages (@dashevo/wallet-lib) / Linting: packages/wallet-lib/src/plugins/Workers/TransactionsSyncWorker/TransactionsReader.spec.js#L24

Unexpected unnamed function

JS packages (@dashevo/wallet-lib) / Linting: packages/wallet-lib/src/plugins/Workers/TransactionsSyncWorker/TransactionsReader.spec.js#L766

Unexpected unnamed async function

JS packages (@dashevo/wallet-lib) / Linting: packages/wallet-lib/src/plugins/Workers/TransactionsSyncWorker/TransactionsReader.spec.js#L801

Unexpected unnamed async function

JS packages (@dashevo/wallet-lib) / Linting: packages/wallet-lib/src/plugins/Workers/TransactionsSyncWorker/TransactionsSyncWorker.spec.js#L881

Unexpected unnamed function

JS packages (@dashevo/wallet-lib) / Linting: packages/wallet-lib/src/test/mocks/dashcore/block.js#L33

Unexpected console statement

JS packages (@dashevo/platform-test-suite) / Linting

Rust packages (drive-abci) / Check each feature

Build Docker images (Drive, drive, drive-abci) / Build Drive image

Input 'config-inline' has been deprecated with message: Use buildkitd-config-inline instead

Build Docker images (Drive, drive, drive-abci) / Build Drive image

Input 'config-inline' has been deprecated with message: Use buildkitd-config-inline instead

Build Docker images (Drive, drive, drive-abci) / Build Drive image

JS packages (@dashevo/wasm-dpp) / Linting

JS packages (@dashevo/wasm-dpp) / Linting: packages/wasm-dpp/test/integration/identity/IdentityFacade.spec.js#L69

Unexpected console statement

JS packages (@dashevo/wasm-dpp) / Linting: packages/wasm-dpp/test/integration/identity/stateTransition/IdentityUpdateTransition/validation/state/validateIdentityUpdateTransitionStateFactory.spec.js#L127

Unexpected unnamed async function

JS packages (@dashevo/wasm-dpp) / Linting: packages/wasm-dpp/test/integration/identity/stateTransition/assetLockProof/chain/validateChainAssetLockProofStructureFactory.spec.js#L310

Unexpected unnamed async function

JS packages (@dashevo/wasm-dpp) / Linting: packages/wasm-dpp/test/integration/identity/stateTransition/assetLockProof/chain/validateChainAssetLockProofStructureFactory.spec.js#L356

Unexpected unnamed async function

JS packages (@dashevo/wasm-dpp) / Linting: packages/wasm-dpp/test/integration/identity/stateTransition/assetLockProof/chain/validateChainAssetLockProofStructureFactory.spec.js#L381

Unexpected unnamed async function

JS packages (@dashevo/wasm-dpp) / Linting: packages/wasm-dpp/test/integration/identity/stateTransition/assetLockProof/fetchAssetLockTransactionOutputFactory.spec.js#L92

Unexpected unnamed async function

JS packages (dash) / Linting

JS packages (dash) / Linting: packages/js-dash-sdk/src/SDK/Client/Client.ts#L10

Dependency cycle via ./Platform:1

JS packages (dash) / Linting: packages/js-dash-sdk/src/SDK/Client/Client.ts#L166

Assignment to function parameter 'options'

JS packages (dash) / Linting: packages/js-dash-sdk/src/SDK/Client/Platform/Fetcher/Fetcher.ts#L143

Returning an awaited value that is not a promise is not allowed

JS packages (dash) / Linting: packages/js-dash-sdk/src/SDK/Client/Platform/Platform.spec.ts#L5

Using exported name 'Client' as identifier for default export

JS packages (dash) / Linting: packages/js-dash-sdk/src/SDK/Client/Platform/Platform.ts#L5

Dependency cycle via ./Platform:10

JS packages (dash) / Linting: packages/js-dash-sdk/src/SDK/Client/Platform/Platform.ts#L5

Using exported name 'Client' as identifier for default export

JS packages (dash) / Linting: packages/js-dash-sdk/src/SDK/Client/Platform/Platform.ts#L8

Dependency cycle detected

JS packages (dash) / Linting: packages/js-dash-sdk/src/SDK/Client/Platform/Platform.ts#L8

Using exported name 'createAssetLockTransaction' as identifier for default export

JS packages (dash) / Linting: packages/js-dash-sdk/src/SDK/Client/Platform/Platform.ts#L10

Dependency cycle detected

JS packages (dash) / Linting: packages/js-dash-sdk/src/SDK/Client/Platform/Platform.ts#L11

Dependency cycle detected

JS packages (@dashevo/dapi-client) / Tests

JS packages (dashmate) / Linting

JS packages (@dashevo/wasm-dpp) / Tests

JS code security audit / Run Code QL

The following actions use a deprecated Node.js version and will be forced to run on node20: strophy/actions-cache@opendal-update, github/codeql-action/init@v2, github/codeql-action/analyze@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

JS code security audit / Run Code QL

CodeQL Action v2 will be deprecated on December 5th, 2024. Please update all occurrences of the CodeQL Action in your workflow files to v3. For more information, see https://github.blog/changelog/2024-01-12-code-scanning-deprecation-of-codeql-action-v2/

JS code security audit / Run Code QL

1 issue was detected with this workflow: Please specify an on.push hook to analyze and see code scanning alerts from the default branch on the Security tab.

JS packages (dashmate) / Tests

JS packages (@dashevo/wallet-lib) / Tests

Dashmate E2E tests (Testnet Evonode, test/e2e/testnetEvonode.spec.js, false) / Run Testnet Evonode tests

Dashmate E2E tests (Testnet fullnode, test/e2e/testnetFullnode.spec.js, false) / Run Testnet fullnode tests

Rust packages (drive) / Tests

Rust packages (drive-abci) / Linting

unused import: `platform_value::Identifier`: packages/rs-dpp/src/state_transition/state_transitions/identity/identity_credit_transfer_transition/v0/v0_methods.rs#L11

this `else { if .. }` block can be collapsed: packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_masternode_identities/update_operator_identity/v0/mod.rs#L268

warning: this `else { if .. }` block can be collapsed --> packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_masternode_identities/update_operator_identity/v0/mod.rs:268:24 | 268 | } else { | ________________________^ 269 | | if let Some((_, found_old_key)) = identity_to_enable_old_keys 270 | | .iter() 271 | | .find(|(_, key)| key.purpose() == Purpose::TRANSFER) ... | 282 | | } 283 | | }; | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if = note: `#[warn(clippy::collapsible_else_if)]` on by default help: collapse nested if block | 268 ~ } else if let Some((_, found_old_key)) = identity_to_enable_old_keys 269 + .iter() 270 + .find(|(_, key)| key.purpose() == Purpose::TRANSFER) 271 + { 272 + Some(found_old_key.data().to_vec().try_into().map_err(|_| { 273 + Error::Execution(ExecutionError::CorruptedDriveResponse( 274 + "old payout address should be 20 bytes".to_string(), 275 + )) 276 + })?) 277 + } else { 278 + // finally we just use the old masternode payout address 279 + // we need to use the old pub_key_operator 280 + old_masternode.state.operator_payout_address 281 ~ }; |

taken reference of right operand: packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_masternode_identities/update_operator_identity/v0/mod.rs#L323

warning: taken reference of right operand --> packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_masternode_identities/update_operator_identity/v0/mod.rs:323:42 | 323 | .find(|(_, key)| key.data().as_slice() == &new_payout_address) | ^^^^^^^^^^^^^^^^^^^^^^^^^------------------- | | | help: use the right value directly: `new_payout_address` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref = note: `#[warn(clippy::op_ref)]` on by default

taken reference of right operand: packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_masternode_identities/update_operator_identity/v0/mod.rs#L347

warning: taken reference of right operand --> packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_masternode_identities/update_operator_identity/v0/mod.rs:347:42 | 347 | .find(|(_, key)| key.data().as_slice() == &new_platform_node_id) | ^^^^^^^^^^^^^^^^^^^^^^^^^--------------------- | | | help: use the right value directly: `new_platform_node_id` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref

unexpected `cfg` condition name: `tokio_unstable`: packages/rs-drive-abci/src/utils/spawn.rs#L13

warning: unexpected `cfg` condition name: `tokio_unstable` --> packages/rs-drive-abci/src/utils/spawn.rs:13:15 | 13 | #[cfg(all(tokio_unstable, feature = "console"))] | ^^^^^^^^^^^^^^ | = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` = help: consider using a Cargo feature instead = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [lints.rust] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(tokio_unstable)'] } = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(tokio_unstable)");` to the top of the `build.rs` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration = note: `#[warn(unexpected_cfgs)]` on by default

unexpected `cfg` condition name: `tokio_unstable`: packages/rs-drive-abci/src/utils/spawn.rs#L20

warning: unexpected `cfg` condition name: `tokio_unstable` --> packages/rs-drive-abci/src/utils/spawn.rs:20:19 | 20 | #[cfg(not(all(tokio_unstable, feature = "console")))] | ^^^^^^^^^^^^^^ | = help: consider using a Cargo feature instead = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [lints.rust] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(tokio_unstable)'] } = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(tokio_unstable)");` to the top of the `build.rs` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

type `platform_types::platform_state::v0::old_structures::ValidatorSet` is more private than the item `platform_types::platform_state::v0::PlatformStateForSavingV0::validator_sets`: packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs#L148

warning: type `platform_types::platform_state::v0::old_structures::ValidatorSet` is more private than the item `platform_types::platform_state::v0::PlatformStateForSavingV0::validator_sets` --> packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs:148:5 | 148 | pub validator_sets: Vec<(Bytes32, old_structures::ValidatorSet)>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ field `platform_types::platform_state::v0::PlatformStateForSavingV0::validator_sets` is reachable at visibility `pub(platform_state)` | note: but type `platform_types::platform_state::v0::old_structures::ValidatorSet` is only usable at visibility `pub(v0)` --> packages/rs-drive-abci/src/platform_types/platform_state/v0/old_structures/mod.rs:7:1 | 7 | pub(super) enum ValidatorSet { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = note: `#[warn(private_interfaces)]` on by default

iterating on a map's keys: packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs#L286

warning: iterating on a map's keys --> packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs:286:36 | 286 | previous_fee_versions: value | ____________________________________^ 287 | | .previous_fee_versions 288 | | .into_iter() 289 | | .map(|(epoch_index, _)| (epoch_index, FeeVersion::first())) | |___________________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map = note: `#[warn(clippy::iter_kv_map)]` on by default help: try | 286 ~ previous_fee_versions: value 287 + .previous_fee_versions.into_keys().map(|epoch_index| (epoch_index, FeeVersion::first())) |

consider using `sort_by_key`: packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs#L450

warning: consider using `sort_by_key` --> packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs:450:9 | 450 | validator_sets.sort_by(|a, b| b.core_height().cmp(&a.core_height())); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `validator_sets.sort_by_key(|b| std::cmp::Reverse(b.core_height()))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by = note: `#[warn(clippy::unnecessary_sort_by)]` on by default

Rust packages (drive-abci) / Tests