Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(platform): add limits to identity balances and proposed block counts queries #2148

Merged
merged 3 commits into from
Sep 19, 2024
Merged

fix(platform): add limits to identity balances and proposed block counts queries #2148

merged 3 commits into from
Sep 19, 2024

Conversation

QuantumExplorer
Copy link
Member

Issue being fixed or feature implemented

There was an issue when getting identity balances without proofs.

What was done?

Added a required limit.
Also added a limit to get proposed block count by ids.

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@QuantumExplorer QuantumExplorer added this to the v1.3.0 milestone Sep 19, 2024
@QuantumExplorer QuantumExplorer added bug Something isn't working dapi-endpoint DAPI endpoint addition or modification labels Sep 19, 2024
kxcd
kxcd approved these changes Sep 19, 2024
View reviewed changes
Copy link

@kxcd kxcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK.

@QuantumExplorer QuantumExplorer changed the title fix(platform): add limits to query fix(platform): add limits to identity balances and proposed block counts queries Sep 19, 2024
@QuantumExplorer QuantumExplorer merged commit b9d3bf7 into v1.3-dev Sep 19, 2024
30 of 35 checks passed
@QuantumExplorer QuantumExplorer deleted the fix/addLimitsToQuery branch September 19, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kxcd kxcd kxcd approved these changes

@shumkov shumkov Awaiting requested review from shumkov

Assignees
No one assigned
Labels
bug Something isn't working dapi-endpoint DAPI endpoint addition or modification
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@QuantumExplorer @kxcd