Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashmate): doctor fails collecting to big logs #2158

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Sep 22, 2024

Issue being fixed or feature implemented

The dashmate doctor command fails to collect big logs (> 900 MB). I am not sure if it's a good idea to send more than 100 MB logs per service. In this case, a sample archive file will be too big and inconvenient to send.

What was done?

  • Limitted collected service log to 300,000 lines (approximately 100 MB of text).

How Has This Been Tested?

Running doctor locally

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v1.4.0 milestone Sep 22, 2024
@shumkov shumkov self-assigned this Sep 22, 2024
@QuantumExplorer QuantumExplorer merged commit 5aab08d into v1.4-dev Sep 26, 2024
21 of 22 checks passed
@QuantumExplorer QuantumExplorer deleted the fix/dashmate/collect-big-logs branch September 26, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants