[feat]: Adapt GCPCluster to be able to initialize the cluster by passing credentials without obtaining from the environment

[RubenBBlazquez]

No description provided.

[jacobtomlinson]

Thanks for taking the time to raise this. It looks very similar to #430, but there are some differences.

I would ask the same questions here:

• Do we need to bump the minimum version of the google auth to support this?
• Can you verify tests are passing locally for you?

[RubenBBlazquez]

Thanks for taking the time to raise this. It looks very similar to #430, but there are some differences.

I would ask the same questions here:

• Do we need to bump the minimum version of the google auth to support this?
• Can you verify tests are passing locally for you?

Hi, about the first question, which is the min version of the google auth?, its not in the requierements.
About the tests i get an error with aws credential but i didnt touch that, you know that could be?
FAILED dask_cloudprovider/aws/tests/test_helper.py::test_aws_to_dict_and_back - ImportError: Dask Cloud Provider AWS requirements are not installed. FAILED dask_cloudprovider/tests/test_imports.py::test_imports - ImportError: Dask Cloud Provider AWS requirements are not installed.
I installed the requirements from the project, but fail that two tests

[jacobtomlinson]

Did you run pip install -e .[all] to install the optional dependencies of each cloud provider?

[RubenBBlazquez]

Did you run pip install -e .[all] to install the optional dependencies of each cloud provider?

about the version of the google-auth, the method exists in the 1.23.0 version, so theres no problem and works well
about the tests I use the command you mention , and installed all the cloud dependencies, but when i try to start the gcp tests and using the --create-external-resources option, most of the tests skip anyways, only one executes

[jacobtomlinson]

That's fine. If you don't have credentials set up it will skip the test. I would expect the GCP tests to run and pass given that you're touching GCP here.

[RubenBBlazquez]

Hi, the code modified in this pr works well in the gcp tests, when i launch the tests the cluster is up correctly (if the gcpCluster connect with gcp is all i modified here and what could fail), and i cant test all of them, they take to much time to execute and finalize, so, i cant afford having the cluster up that time

[jacobtomlinson]

That's fine. I appreciate you testing the modified code locally.