Add wheels.yml workflow for release to PyPI #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milesgranger
force-pushed
the
milesgranger/add-release-workflow
branch
10 times, most recently
from
ada962c
to
0a6c372
Compare
milesgranger
force-pushed
the
milesgranger/add-release-workflow
branch
from
0a6c372
to
07dd845
Compare
milesgranger
had a problem deploying
to
testpypi
GitHub Actions
Failure
milesgranger
force-pushed
the
milesgranger/add-release-workflow
branch
from
07dd845
to
ee03ffa
Compare
milesgranger
had a problem deploying
to
releases
GitHub Actions
Failure
milesgranger
force-pushed
the
milesgranger/add-release-workflow
branch
from
ee03ffa
to
cf327ac
Compare
fjetter
reviewed
Nov 6, 2023
Comment on lines
+4
to
+5
| push: | ||
| pull_request: |
There was a problem hiding this comment.
Does this actually have to run on push/pull_request? I would expect release to be sufficient. push maybe but only for main?
There was a problem hiding this comment.
Ya, I did that because the actual uploading does a check for tags being present.
if: "startsWith(github.ref, 'refs/tags/')"
Thought maybe it'd be useful to ensure the project builds successfully, but maybe it's overkill.
fjetter
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.