Fixes to Actions and Transformers

[pbo-cirus]

This PR contains:

• Updates to latest Cloud-vision plugin.
• Update to Output schema.
• Fixed the spacing in the source files.

Known Issues:

https://issues.cask.co/browse/PLUGIN-120

Errors in pipeline run on Sandbox environment only.

Note: Examples will be sent in another PR.

[bdmogal]

@pbo-cirus made some initial comments. Thanks a lot for fixing the indentation changes for the most part. Could you also please remove the package-info.java files - we generally don't add them in plugin code.

[pbo-cirus]

Ok, I'll work on it tomorrow. Thanks.

…

On Thu, Apr 9, 2020, 9:18 PM Bhooshan Mogal ***@***.***> wrote: ***@***.**** requested changes on this pull request. @pbo-cirus <https://github.com/pbo-cirus> made some initial comments. Thanks a lot for fixing the indentation changes for the most part. Could you also please remove the package-info.java files - we generally don't add them in plugin code. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#15 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APDAA6HU6IYJOXTYFA4TBUTRLZXWLANCNFSM4MFDDGFQ> .

[atigyi]

why is this removed? This makes the build not include the plugins. The target/.jar size isn't 22Mb but 128Kb. And using the REST api to upload the .jar throws <title>Error 400 (Bad Request)!!1</title>. But even after adding back this part the <title>Error 400 (Bad Request)!!1</title> still remains.
I build the project with mvn -Dmaven.test.skip=true package, what can be the problem? Could you help please?

[pbo-cirus]

I agree, this should not have been removed.

[atigyi]

👍 thx

[atigyi]

Hi, I've built both branches cirus-code and cirus-example, first had rat-check errors, second had checkstyle errors during the build. I've turned these off, even added back the _exportcontents tag to include the plugins in the .jar.
After having the .jar, used the REST api to upload the plugin, but it resulted in <title>Error 400 (Bad Request)!!1</title>.
Is there something I do wrong?
Thanks in advance.

[pbo-cirus]

I fixed the pom and now it builds correctly.

Also, the examples are in a separate PR but will only work on this version. We were asked to separate them out into two PRs.