updated correct conn string,

removed space in yml, removed verify goal in pom. changed sql connector java version to run in github actions and bqmt secret updated
data-integrations · Dec 20, 2023 · d808e6f · d808e6f
1 parent ab3c7fc
commit d808e6f
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 9 deletions.
diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml
@@ -79,7 +79,7 @@ jobs:
                         MYSQL_USERNAME:cdapio-github-builds/MYSQL_USERNAME
                         MYSQL_PASSWORD:cdapio-github-builds/MYSQL_PASSWORD
                         MYSQL_PORT:cdapio-github-builds/MYSQL_PORT
-                        CONNECTION_STRING:cdapio-github-builds/CONNECTION_STRING
+                        BQMT_CONNECTION_STRING:cdapio-github-builds/BQMT_CONNECTION_STRING
 
       - name: Run required e2e tests
         if: github.event_name != 'workflow_dispatch' && github.event_name != 'push' && steps.filter.outputs.e2e-test == 'false'
@@ -89,7 +89,7 @@ jobs:
           MYSQL_USERNAME: ${{ steps.secrets.outputs.MYSQL_USERNAME }}
           MYSQL_PASSWORD: ${{ steps.secrets.outputs.MYSQL_PASSWORD }}
           MYSQL_PORT: ${{ steps.secrets.outputs.MYSQL_PORT }}
-          CONNECTION_STRING: ${{ steps.secrets.outputs.CONNECTION_STRING }}
+          BQMT_CONNECTION_STRING: ${{ steps.secrets.outputs.BQMT_CONNECTION_STRING }}
 
       - name: Run all e2e tests
         if: github.event_name == 'workflow_dispatch' || github.event_name == 'push' || steps.filter.outputs.e2e-test == 'true'
@@ -99,22 +99,20 @@ jobs:
           MYSQL_USERNAME: ${{ steps.secrets.outputs.MYSQL_USERNAME }}
           MYSQL_PASSWORD: ${{ steps.secrets.outputs.MYSQL_PASSWORD }}
           MYSQL_PORT: ${{ steps.secrets.outputs.MYSQL_PORT }}
-          CONNECTION_STRING: ${{ steps.secrets.outputs.CONNECTION_STRING }}
+          BQMT_CONNECTION_STRING: ${{ steps.secrets.outputs.BQMT_CONNECTION_STRING }}
 
       - name: Upload report 
         uses: actions/upload-artifact@v3
         if: always()
         with:
           name: Cucumber report - ${{ matrix.tests }}
           path: ./plugin/target/cucumber-reports
-
       - name: Upload debug files 
         uses: actions/upload-artifact@v3
         if: always()
         with:
           name: Debug files - ${{ matrix.tests }}
           path: ./**/target/e2e-debug
-
       - name: Upload files to GCS
         uses: google-github-actions/upload-cloud-storage@v0
         if: always()

diff --git a/pom.xml b/pom.xml
@@ -1,5 +1,4 @@
 <?xml version="1.0" encoding="UTF-8"?>
-
 <!--
   ~ Copyright © 2016-2019 Cask Data, Inc.
   ~
@@ -1195,7 +1194,6 @@
           <execution>
             <goals>
               <goal>integration-test</goal>
-              <goal>verify</goal>
             </goals>
           </execution>
         </executions>
@@ -1246,7 +1244,7 @@
         <dependency>
           <groupId>mysql</groupId>
           <artifactId>mysql-connector-java</artifactId>
-          <version>8.0.19</version>
+          <version>8.0.25</version>
           <scope>test</scope>
         </dependency>
         <dependency>

diff --git a/src/e2e-test/resources/pluginParameters.properties b/src/e2e-test/resources/pluginParameters.properties
@@ -238,7 +238,7 @@ host=MYSQL_HOST
 user=MYSQL_USERNAME
 pass=MYSQL_PASSWORD
 port=MYSQL_PORT
-connectionString=CONNECTION_STRING
+connectionString=BQMT_CONNECTION_STRING
 mySQLSourceTable=dummy
 sourceTable=dummy
 tableNameField=tableName