Fix nullable fields handling with JSON source #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@VictorD-Veolia do you mind sharing the exact issue (some sample response for which the plugin failed before the fix)? If you can add a test to demonstrate it, that would be even better. |
|
Also, since this repository does not have automatic builds set up yet, would it be possible to paste the output of |
|
Hi @bdmogal, I added a unit test and created an issue in JIRA : https://cdap.atlassian.net/browse/PLUGIN-805 I also added to this comment the output of the |
fernst
reviewed
Mar 18, 2022
pom.xml
Outdated
| @@ -82,7 +82,7 @@ | |||
| <gson.version>2.8.5</gson.version> | |||
| <hadoop.version>2.3.0</hadoop.version> | |||
| <httpcomponents.version>4.5.9</httpcomponents.version> | |||
| <hydrator.version>2.4.0-SNAPSHOT</hydrator.version> | |||
| <hydrator.version>2.4.0</hydrator.version> | |||
There was a problem hiding this comment.
We should bump to a release version in the develop branch
rmstar
reviewed
Mar 18, 2022
| @@ -0,0 +1,109 @@ | |||
| /* | |||
| * Copyright © 2019-2020 Cask Data, Inc. | |||
rmstar
approved these changes
May 21, 2022
| @@ -82,7 +82,7 @@ | |||
| <gson.version>2.8.5</gson.version> | |||
| <hadoop.version>2.3.0</hadoop.version> | |||
| <httpcomponents.version>4.5.9</httpcomponents.version> | |||
| <hydrator.version>2.4.0-SNAPSHOT</hydrator.version> | |||
| <hydrator.version>2.10.0-SNAPSHOT</hydrator.version> | |||
There was a problem hiding this comment.
This should be set to a non-snapshot version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an error in JSONPage that prevented HTTP sources to handle nullable fields correctly.