Fix IncrementAnIndexPaginationIterator #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@VictorD-Veolia: possible to share the exact problem that this fixes? Some sample response that this fails for? Also, could you add a test? |
|
The "Increment An Index" pagination is not usable at all. Having a pipeline with an HTTP plugin using "Increment an Index" pagination will throw "Failed to configure pipeline: Stage 'HTTP' encountered : Null error occurred while configuring the stage HTTP." at pipeline startup (with every configuration and independently of input data). |
rmstar
reviewed
May 21, 2022
| @@ -31,9 +31,6 @@ | |||
| import java.util.List; | |||
| import java.util.Map; | |||
|
|
|||
| /** | |||
| * Returns elements from json one by one by given json path. | |||
| this.json = JSONUtil.toJsonElement(httpResponse.getBody()); | ||
| this.schema = config.getSchema(); | ||
| this.optionalFields = getOptionalFields(); | ||
|
|
||
| JsonElement jsonElement = json; | ||
| if (json.isJsonObject()) { | ||
| JSONUtil.JsonQueryResponse queryResponse = | ||
| JSONUtil.getJsonElementByPath(json.getAsJsonObject(), config.getResultPath(), optionalFields); | ||
| JSONUtil.getJsonElementByPath(json.getAsJsonObject(), config.getResultPath(), optionalFields); |
| this.iterator = Collections.singleton(jsonElement).iterator(); | ||
| } else { | ||
| throw new IllegalArgumentException(String.format("Element found by '%s' json path is expected to be an object " + | ||
| "or an array. Primitive found", config.getResultPath())); | ||
| "or an array. Primitive found", config.getResultPath())); |
| * Example next element: | ||
| * { |
| * { | ||
| * "key":"NETTY-13", |
| @@ -196,7 +206,7 @@ private List<String> getOptionalFields() { | |||
| public String getPrimitiveByPath(String path) { | |||
| if (json.isJsonObject()) { | |||
| JSONUtil.JsonQueryResponse queryResponse = JSONUtil.getJsonElementByPath(json.getAsJsonObject(), | |||
| path, optionalFields); | |||
| path, optionalFields); | |||
| JsonPage(BaseHttpSourceConfig config, HttpResponse httpResponse) { | ||
| super(httpResponse); | ||
| this.config = config; | ||
| String body = httpResponse.getBody(); |
| @@ -43,17 +40,19 @@ class JsonPage extends BasePage { | |||
| private final BaseHttpSourceConfig config; | |||
| private final List<String> optionalFields; | |||
|
|
|||
| // TODO : handle case where the result json object is null | |||
There was a problem hiding this comment.
what happens when result json object is null? are you planning to handle that case in another PR?
| InvalidEntry<StructuredRecord> error = | ||
| new InvalidEntry<>(1, "Couldn't find all required fields in the record", record); | ||
| return new PageEntry(error, config.getErrorHandling()); | ||
| if (iterator.hasNext()) { |
There was a problem hiding this comment.
you can avoid one level of indent if you return when there are no entries:
if (!iterartor.hasNext()) {
return new PageEntry(null);
}
...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix "Increment An Index" Pagination to match the expected behavior when "maxIndex" is null ("If empty, pagination will happen until the page with no elements.").