Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to use particular certificate for client during 2 way ssl connection #72

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

dgrinenko
Copy link

@dgrinenko dgrinenko commented Dec 14, 2021

JIRA: https://cdap.atlassian.net/browse/PLUGIN-1008

The issue:
In some cases, java struggling to auto-detect the proper client certificate for the 2-way SSL connection in the truststore, especially if the certificate contains custom constraints. It prevents plugin to establish a secure 2 way ssl connection

What need to be done:
In such cases - http plugin should provide possibility to ask user for specific certificate alias in the keystore, to use it later for client connection instead of trying to auto-detect it

What was done:

  • Added new configuration item for the plugin - "Keystore Cert Alias"
  • In case, if user set the alias for certificate, plugin would try to use it, instead of trying to auto-detect
  • The feature is supported only for X.509 keystores/certificates

Unit tests passed:

Results :

Tests run: 41, Failures: 0, Errors: 0, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  03:48 min
[INFO] Finished at: 2021-12-14T15:02:38+02:00
[INFO] ------------------------------------------------------------------------

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant