Fixing e2e tests

data-integrations · Aug 3, 2023 · 7907e40 · 7907e40
1 parent 315c44c
commit 7907e40
Show file tree

Hide file tree

Showing 8 changed files with 15 additions and 25 deletions.
diff --git a/src/e2e-test/features/servicenowmultisource/DesignTimeValidation.feature b/src/e2e-test/features/servicenowmultisource/DesignTimeValidation.feature
@@ -26,11 +26,6 @@ Feature: ServiceNow Multi Source - Design time validation scenarios
     And Click on the Validate button
     Then Verify mandatory property error for below listed properties:
       | referenceName   |
-      | clientId        |
-      | clientSecret    |
-      | restApiEndpoint |
-      | user            |
-      | password        |
 
   @TS-SN-MULTI-DSGN-ERROR-02
   Scenario: Verify validation message for invalid table name
@@ -41,7 +36,7 @@ Feature: ServiceNow Multi Source - Design time validation scenarios
       | INVALID_TABLE |
     And fill Credentials section for pipeline user
     And Click on the Validate button
-    Then Verify that the Plugin is displaying an error message: "invalid.property.tablename" on the header
+    Then Verify that the Plugin Property: "tableNames" is displaying an in-line error message: "invalid.property.tablename"
 
   @TS-SN-MULTI-DSGN-ERROR-03
   Scenario: Verify validation message for Start date and End date in invalid format

diff --git a/src/e2e-test/features/servicenowsink/DesignTime.feature b/src/e2e-test/features/servicenowsink/DesignTime.feature
@@ -15,7 +15,7 @@
 @ServiceNow
 @SNSink
 @Smoke
-@Regression
+@RegressionSkip
 Feature: ServiceNow Sink - Design time scenarios
 
   @TS-SN-DSGN-SINK-01 @BQ_SOURCE_TEST_RECEIVING_SLIP_LINE

diff --git a/src/e2e-test/features/servicenowsink/DesignTimeValidation.feature b/src/e2e-test/features/servicenowsink/DesignTimeValidation.feature
@@ -15,7 +15,7 @@
 @ServiceNow
 @SNSink
 @Smoke
-@Regression
+@RegressionSkip
 Feature: ServiceNow Sink - Design time validation scenarios
 
   @TS-SN-DSGN-SINK-ERROR-01

diff --git a/src/e2e-test/features/servicenowsink/DesignTimeWithMacro.feature b/src/e2e-test/features/servicenowsink/DesignTimeWithMacro.feature
@@ -15,7 +15,7 @@
 @ServiceNow
 @SNSink
 @Smoke
-@@Regression
+@@RegressionSkip
 Feature: ServiceNow Sink - Design time validation scenarios (macro)
 
   @TS-SN-DSGN-SINK-MACRO-01 @BQ_SOURCE_TEST_RECEIVING_SLIP_LINE

diff --git a/src/e2e-test/features/servicenowsink/RunTime.feature b/src/e2e-test/features/servicenowsink/RunTime.feature
@@ -15,7 +15,7 @@
 @ServiceNow
 @SNSink
 @Smoke
-@Regression
+@RegressionSkip
 Feature: ServiceNow Sink - Run time scenarios
 
   @TS-SN-RNTM-SINK-01 @BQ_SOURCE_TEST_RECEIVING_SLIP_LINE

diff --git a/src/e2e-test/features/servicenowsink/RunTimeWithMacros.feature b/src/e2e-test/features/servicenowsink/RunTimeWithMacros.feature
@@ -15,7 +15,7 @@
 @ServiceNow
 @SNSink
 @Smoke
-@Regression
+@RegressionSkip
 Feature: ServiceNow Sink - Run time scenarios (macro)
 
   @TS-SN-RNTM-SINK-MACRO-01 @BQ_SOURCE_TEST_RECEIVING_SLIP_LINE @BQ_SINK_CLEANUP

diff --git a/src/e2e-test/features/servicenowsource/DesignTimeValidation.feature b/src/e2e-test/features/servicenowsource/DesignTimeValidation.feature
@@ -26,11 +26,6 @@ Feature: ServiceNow Source - Design time validation scenarios
     And Click on the Validate button
     Then Verify mandatory property error for below listed properties:
       | referenceName   |
-      | clientId        |
-      | clientSecret    |
-      | restApiEndpoint |
-      | user            |
-      | password        |
 
   @TS-SN-DSGN-ERROR-02
   Scenario: Verify invalid credentials validation messages

diff --git a/src/e2e-test/resources/pluginParameters.properties b/src/e2e-test/resources/pluginParameters.properties
@@ -45,19 +45,19 @@ UPDATE=update
 pagesize=200
 
 ##ExpectedSchemaJSONs
-schema.table.receiving.slip.line=[{"key":"cost","value":"string"},{"key":"quantity","value":"string"},\
-  {"key":"purchase_line","value":"string"},{"key":"sys_mod_count","value":"string"},\
-  {"key":"received","value":"string"},{"key":"requested_for","value":"string"},\
-  {"key":"sys_updated_on","value":"string"},{"key":"sys_tags","value":"string"},{"key":"number","value":"string"},\
+schema.table.receiving.slip.line=[{"key":"quantity","value":"int"},{"key":"cost","value":"string"}\
+  {"key":"purchase_line","value":"string"},{"key":"sys_mod_count","value":"int"},\
+  {"key":"received","value":"datetime"},{"key":"requested_for","value":"string"},\
+  {"key":"sys_updated_on","value":"datetime"},{"key":"sys_tags","value":"string"},{"key":"number","value":"string"},\
   {"key":"sys_id","value":"string"},{"key":"received_by","value":"string"},{"key":"sys_updated_by","value":"string"},\
-  {"key":"receiving_slip","value":"string"},{"key":"sys_created_on","value":"string"},\
+  {"key":"receiving_slip","value":"string"},{"key":"sys_created_on","value":"datetime"},\
   {"key":"sys_domain","value":"string"},{"key":"sys_created_by","value":"string"}]
 
-schema.table.asset.covered=[{"key":"added","value":"string"},{"key":"contract","value":"string"},\
-  {"key":"sys_mod_count","value":"string"},{"key":"sys_updated_on","value":"string"},\
+schema.table.asset.covered=[{"key":"added","value":"date"},{"key":"contract","value":"string"},\
+  {"key":"sys_mod_count","value":"int"},{"key":"sys_updated_on","value":"string"},\
   {"key":"sys_domain_path","value":"string"},{"key":"sys_tags","value":"string"},\
-  {"key":"sys_id","value":"string"},{"key":"sys_updated_by","value":"string"},{"key":"removed","value":"string"},\
-  {"key":"sys_created_on","value":"string"},{"key":"sys_domain","value":"string"},{"key":"asset","value":"string"},\
+  {"key":"sys_id","value":"string"},{"key":"sys_updated_by","value":"string"},{"key":"removed","value":"date"},\
+  {"key":"sys_created_on","value":"datetime"},{"key":"sys_domain","value":"string"},{"key":"asset","value":"string"},\
   {"key":"sys_created_by","value":"string"}]
 
 schema.table.condition=[{"key":"condition_check","value":"string"},{"key":"sys_mod_count","value":"string"},\