-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default file format when Quarto format is typst
#7
Merged
Merged
Changes from 3 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
44b7fb0
Add default SVG format for Typst output
elipousson edd3bee
Remove duplicate theme
elipousson 5e2452c
Allow uppercase layout values
elipousson 2a53f48
Fix d2 class check
elipousson b9b8a83
Update CHANGELOG.md
elipousson 74de52c
Use d2-render instead of svg-convert for temp directory
elipousson 86b89c0
Add support for gif format
elipousson 2b94f40
Use outputPath (not mediabag) if folder is supplied
elipousson 288ffe3
Update README
elipousson 028673e
Fix typo
elipousson 268c635
Fix error in inline embedding logic
elipousson 712aeb7
Add check for d2 or txt file extension in file option
elipousson 0e132ea
Update README
elipousson 9a21d23
Merge branch 'main' into main
elipousson 95fc8f3
Add partial support for code folding (#6)
elipousson 9e71abf
Add typst format tests w/ multiple diagram formats
elipousson bf5c501
Update CHANGELOG.md
rcannood File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why add a random number to this filename?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had an issue with the extension not overwriting existing files that this seemed to resolve. I’ll try to put together a reprex (it may be specifically related to using knit_child?) to see if this random number assignment is a real fix or if there may be a better way to fix the issue.