Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cross browser audit #36

Closed
wants to merge 17 commits into from
Closed

feat: cross browser audit #36

wants to merge 17 commits into from

Conversation

tikagan
Copy link
Collaborator

@tikagan tikagan commented Sep 26, 2023

Description

  • updates font files to fix font weight irregularities in the headers + buttons
  • primary cta button polish, background color + glow slightly more opaque
  • adds missing copy from accordion card "Effortless Deal Tracking"
  • removes focus ring on hover from github + slack ctas in subfooter card styling
  • changes secondary cta arrow to icon instead of unicode character
  • signup form country dropdown shows 7 fields, solid background color when open
  • signup form submit button doesn't show loading animation after successful form submit
  • primary cta on safari svg shape (on the left) renders as a smooth shape
  • in iOS safari primary cta is a rectangle not custom shape, fixes shape disappearing on iOS because of high paint requirements
  • page data in state doesn't clear when navigating pages, fixes no footer rendering on signup page

Not addressed in this PR:

  • accordion animation jerky on safari
  • email data validation in forms

requested changes (noted in ticket):

  • data storage units displayed as superscript
  • [ ]

Screenshots

Ticket link

Ticket AU-2950

@tikagan tikagan closed this Sep 26, 2023
@tikagan tikagan deleted the feat-cross-browser-audit branch September 27, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants