Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: form data validation #37

Merged
merged 9 commits into from
Sep 29, 2023
Merged

feat: form data validation #37

merged 9 commits into from
Sep 29, 2023

Conversation

tikagan
Copy link
Collaborator

@tikagan tikagan commented Sep 26, 2023 •
edited
Loading

Description

  • improve regexes
  • regex validation on both forms
  • trim whitespace before submitting data
  • corresponding error messages appear when there's a validation issue for a particular field
  • error messages wrap correctly on mobile

Screenshots

Ticket link

Ticket AU-2982

@tikagan tikagan requested a review from orvn September 27, 2023 16:54
@tikagan tikagan mentioned this pull request Sep 27, 2023
Closed
orvn
orvn approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@orvn orvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested a variety of form input cases, looks great!

@tikagan would you mind resolving merge conflicts? After that, feel free to merge.

@tikagan tikagan merged commit 583a11f into main Sep 29, 2023
@tikagan tikagan deleted the feat-form-data-validation branch September 29, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orvn orvn orvn approved these changes

Assignees

@tikagan tikagan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tikagan @orvn