Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: image optimization updates #56

Merged
merged 3 commits into from
Oct 6, 2023
Merged

feat: image optimization updates #56

merged 3 commits into from
Oct 6, 2023

Conversation

tikagan
Copy link
Collaborator

@tikagan tikagan commented Oct 2, 2023 •
edited
Loading

Description

  • footer image updated + styling, no longer overlaps and blocks off parts of the subfooter section
  • optimized warped torus background image

based on requested changes:

  • signup page uses warped-torus-background layout to better size background image to any browser size

Screenshots

Ticket link

Ticket AU-2924

@tikagan tikagan marked this pull request as ready for review October 3, 2023 17:55
@tikagan tikagan requested review from jfmerced and orvn October 3, 2023 17:55
jfmerced
jfmerced suggested changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@jfmerced jfmerced left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image looks fine on chrome and on different viewports, but on Safari and Firefox there's a weird cutoff under the footer:

Screenshot 2023-10-03 at 11 27 10 AM

@tikagan tikagan requested a review from jfmerced October 4, 2023 15:58
jfmerced
jfmerced approved these changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@jfmerced jfmerced left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@orvn orvn merged commit 3fbcae8 into main Oct 6, 2023
2 checks passed
@orvn orvn deleted the feat-image-optimization branch October 6, 2023 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfmerced jfmerced jfmerced approved these changes

@orvn orvn orvn approved these changes

Assignees

@tikagan tikagan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tikagan @orvn @jfmerced