Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Fixing error where complex column types contain a list or null #403

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jhsb25
Copy link

@jhsb25 jhsb25 commented Sep 20, 2023

Current when i use the tool to generate a table from a source that needs to be flattened i get an error when the columns are either null or of a json list format, this PR goes some way to try to ensure that all variant columns queried return a non null value and when the variant in the column is not an object (eg list) then that denesting is skipped.

…t or string), also changing query to pull row where all variant columns have a value
…t or string), also changing query to pull row where all variant columns have a value
@jhsb25 jhsb25 changed the title Fixing error where complex column types contain a list or null fix Fixing error where complex column types contain a list or null Sep 20, 2023
…t or string), also changing query to pull row where all variant columns have a value
@BAntonellini
Copy link
Collaborator

hi @jhsb25, thank you for your contribution

would you be able to provide a test that covers this code you are introducing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants