Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:DCV-1933 changes to env_var and json flattening #406

Conversation

BAntonellini
Copy link
Collaborator

  • Rename env_vars to env_var to match dbt-core naming
  • Change json flattening flag type from Boolean to String, allowing 'yes', 'no' and 'ask'

- Rename env_vars to env_var to match dbt-core naming
- Change json flattening flag type from Boolean to String, allowing 'yes', 'no' and 'ask'
@codecov-commenter
Copy link

Codecov Report

Attention: 231 lines in your changes are missing coverage. Please review.

Comparison is base (c9fcd60) 44.65% compared to head (21e7a6f) 45.95%.
Report is 93 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #406      +/-   ##
==========================================
+ Coverage   44.65%   45.95%   +1.29%     
==========================================
  Files          34       35       +1     
  Lines        2770     2927     +157     
==========================================
+ Hits         1237     1345     +108     
- Misses       1533     1582      +49     
Flag Coverage Δ
unittests 45.95% <46.15%> (+1.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
dbt_coves/__init__.py 100.00% <100.00%> (ø)
dbt_coves/config/config.py 89.93% <100.00%> (-0.07%) ⬇️
dbt_coves/tasks/dbt/main.py 41.09% <100.00%> (+1.65%) ⬆️
dbt_coves/tasks/extract/fivetran.py 38.70% <100.00%> (+2.04%) ⬆️
dbt_coves/tasks/generate/main.py 100.00% <ø> (ø)
dbt_coves/tasks/generate/metadata.py 23.60% <100.00%> (+0.96%) ⬆️
dbt_coves/tasks/generate/properties.py 34.12% <100.00%> (+1.06%) ⬆️
dbt_coves/tasks/generate/templates.py 44.68% <100.00%> (+2.45%) ⬆️
dbt_coves/tasks/setup/main.py 100.00% <100.00%> (ø)
dbt_coves/utils/jinja.py 100.00% <100.00%> (ø)
... and 16 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ssassi ssassi assigned mprunell and unassigned mbarraco Nov 1, 2023
@ssassi ssassi merged commit 6b6e5ff into main Nov 7, 2023
3 checks passed
@ssassi ssassi deleted the DCV-1933-dbt-coves-make-env-var-dbt-consistent-allow-not-flattening-of-json-fields branch November 7, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants