Spicerack #1612
Open
Spicerack #1612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
lib/index.js
Outdated
| preppedData.assets[normalizedAssetType][normalizedAssetName][ext] = | ||
| this.getStaticPath(path); | ||
| }); | ||
| preppedData.assets[normalizedAssetType][normalizedAssetName][ext] = |
Check warning
Code scanning / CodeQL
Prototype-polluting assignment Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 9 days ago
To fix the problem, we need to ensure that the keys used in the preppedData object cannot lead to prototype pollution. This can be achieved by:
- Validating the
assetNameandassetTypeto ensure they do not contain dangerous values like__proto__,constructor, orprototype. - Using a
Mapobject instead of a plain object forpreppedData.assetsto avoid prototype pollution.
The best way to fix the problem without changing existing functionality is to implement both of these measures. We will validate the keys and use a Map for preppedData.assets.
Suggested changeset
1
lib/index.js
| @@ -308,3 +308,3 @@ | ||
| const preppedData = { | ||
| assets: {}, | ||
| assets: new Map(), | ||
| additionalData: [] | ||
| @@ -361,7 +361,11 @@ | ||
|
|
||
| if (!preppedData.assets[normalizedAssetType]) { | ||
| preppedData.assets[normalizedAssetType] = {}; | ||
| if (['__proto__', 'constructor', 'prototype'].includes(normalizedAssetType) || ['__proto__', 'constructor', 'prototype'].includes(normalizedAssetName)) { | ||
| throw new Error('Invalid assetType or assetName'); | ||
| } | ||
|
|
||
| preppedData.assets[normalizedAssetType][normalizedAssetName] = {}; | ||
| if (!preppedData.assets.has(normalizedAssetType)) { | ||
| preppedData.assets.set(normalizedAssetType, new Map()); | ||
| } | ||
|
|
||
| preppedData.assets.get(normalizedAssetType).set(normalizedAssetName, new Map()); | ||
|
|
||
| @@ -376,4 +380,3 @@ | ||
|
|
||
| preppedData.assets[normalizedAssetType][normalizedAssetName][ext] = | ||
| this.getStaticPath(path); | ||
| preppedData.assets.get(normalizedAssetType).get(normalizedAssetName).set(ext, this.getStaticPath(path)); | ||
| }); |
Copilot is powered by AI and may make mistakes. Always verify output.
# Conflicts: # lib/index.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.