Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor:GitHub action #174

Merged

Conversation

shreelakshmijoshi
Copy link
Collaborator

  • Please refer to the code of conduct : link

  • Please check if the PR fulfills these requirements 📋

  • The commit message follows our guidelines : link
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • A new branch is created for the change(s) and the changes are not committed on the main or master branch
  • No credentials or secrets are committed
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, refactor, chore, test, config) 💁 📜

    Describe the changes

  • Fixes 🔧 # (issue)

  • Checklist for the current PR 📃

  • I have made corresponding changes to the documentation
  • I have added the respective changes in the example-config if the changes are made in config
  • For the changes made in example-config, backend components (elasticsearch, flyway files for postgres, immudb schema, rabbitmq) I have notified DX DevOps team by mentioning [at-sign]datakaveri/devops as a PR comment to help facilitate the further necessary changes
  • I have mentioned the DX Catalogue items required in resources-used
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • pmd, check style issues are resolved locally
  • I have added reviewers to check the proposed changes
  • Please delete the content that is not relevant.

@shreelakshmijoshi shreelakshmijoshi merged commit 44ebf8a into datakaveri:main Sep 5, 2024
1 check passed
@jenkins-datakaveri
Copy link

Build finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants