Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/authentication #178

Conversation

shreelakshmijoshi
Copy link
Collaborator

@shreelakshmijoshi shreelakshmijoshi commented Sep 18, 2024

  • Please refer to the code of conduct : link

  • Please check if the PR fulfills these requirements 📋

  • The commit message follows our guidelines : link
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • A new branch is created for the change(s) and the changes are not committed on the main or master branch
  • No credentials or secrets are committed
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, refactor, chore, test, config) 💁 📜
    refactor
  • RoutingContextHelper to add and fetch information from routing context using static methods
  • Made the create method non-static in Auth Handler class
  • Refactored IudxRole to DxRole
  • Added a separate AuthHandler for Verify Policy
  • Checklist for the current PR 📃
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • pmd, check style issues are resolved locally
  • I have added reviewers to check the proposed changes

Added routing context helper to add and fetch objects from routing context
Refactored classes related to authentication and authorization by <br> 1.Having seperate handlers for authentication, authorization <br> 2. Having seperate AuthHandler for verify policy <br> 3. Changed AuthHandler to have non-static create method <br> 4. Static methods in RoutingContextHelper to add and get info from routing context
Refactored classes related to auth
entication and authorization by <br> 1.Having seperate handlers for authentication, authorization <br> 2. Having seperate AuthHandler for verify policy <br> 3. Changed AuthHandler to have non-static create method <br> 4. Static methods in RoutingContextHelper to add and get info from routing context
@jenkins-datakaveri
Copy link

Build finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants