feat: add simple RDMA communication support #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Server handles both HTTP and RDMA requests through `serve_with_rdma`. Client has two options to communicate with the server: either HTTP via Channel or RDMA via RdmaChannel. RDMA communication based on `async-rdma` crate.
Client establishess an RDMA connection to the server through `connect_rdma`.
rogercloud
reviewed
Dec 10, 2022
| @@ -146,6 +168,27 @@ fn generate_connect(service_ident: &syn::Ident, enabled: bool) -> TokenStream { | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(feature = "transport")] | |||
| fn generate_connect_rdma(service_ident: &syn::Ident, enable: bool) -> TokenStream { | |||
There was a problem hiding this comment.
http version ignores the enable parameter, why do we care about it?
| ); | ||
|
|
||
| // if !disable_comments.contains(&format!( | ||
| // "{}{}{}.{}", |
| @@ -197,6 +240,139 @@ fn generate_methods<T: Service>( | |||
| stream | |||
| } | |||
|
|
|||
| fn generate_methods_rdma<T: Service>( | |||
There was a problem hiding this comment.
try not to duplicate the code if many are the same or similar.
GTwhy
reviewed
Dec 11, 2022
| // body | ||
| source | ||
| .for_each(|item| { | ||
| len += encoder.encode_into_slice(item, &mut buf).unwrap(); |
There was a problem hiding this comment.
How to make sure the len is within mr's len?
If you ensure that by MAX_MSG_LEN, you can add a comment to explain why is it that number.
| pub trait RdmaService { | ||
| /// | ||
| fn alloc_mr(&self) -> io::Result<LocalMr>; | ||
| /// |
|
|
||
| // TODO: handle this error | ||
| async fn rdma_serve_inner(rdma: Arc<Rdma>, mut routes: RdmaRoutes) -> Result<(), io::Error> { | ||
| println!("[server] connected!"); |
| @@ -0,0 +1,202 @@ | |||
| use std::collections::HashMap; | |||
There was a problem hiding this comment.
Maybe we can add this example to github action as a test and show the usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently tonic only supports HTTP, so I tried to add optional RDMA communication feature.
Using RDMA(if machine supports) can improve communication efficiency.
Solution
RDMA communication based on
async-rdmacrate. RDMA establishes a connection via TCP, then communicates using SEND/RECV operations.Server handles both HTTP and RDMA requests through
serve_with_rdma. This function listens to two TCP ports, which are used for HTTP and RDMA connection establishment respectively.Client has two options to communicate with the server: either HTTP via Channel(
connect) or RDMA via RdmaChannel(connect_rdma).