Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up second write in snapshot mode #362

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

hongyuntw
Copy link

@hongyuntw hongyuntw commented Mar 12, 2024

#357 We can pre-check if the bio is first write or not, only the first write need make read clone.

In the origin version
1 second write -> 1 read clone + 1 write (disk)

And this commit can optimize some second writes speed (if the second write bio bitmap is in memory) we can perform
1 second write -> 1 write (disk)

@Swistusmen
Copy link
Contributor

Thanks, I think we are going to review it after filling the goals for the next release (you know first, new features, than optimizations). So your PR with feature test will go first, than mine new features, than probably another with bug fix, and than we could start improving code. So I think I will return here between mid of apirl and mid of may

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants