cpp.ansi, em_m2: include correct prototype for sprint( ). #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should mostly fix the crashes which were observed on GitHub CI (e.g. https://github.com/davidgiven/ack/actions/runs/11410639087/job/31753347141) when building ACK for a macOS host on 64-bit ARM. It turns out that Apple's ARM64 ABI handles variable arguments in variadic functions differently from named arguments (developer.apple.com/documentation/xcode/application-binary-interfaces). Thus callees which want to call the variadic function sprint( ) must declare the correct prototype, otherwise they will pass arguments to it wrongly.
|
Fantastic, thank you. I did wonder if ARM64 might be the issue, but I don't have an Apple ARM64 device, and it worked fine on Linux due to the different ABI. At some stage someone (probably me) needs to bite the bullet and add the flag to error out on undeclared functions... |
|
Hello @davidgiven, Thank you! I guess one issue is that the And unfortunately there seem to be quite a lot of these old-style thingies in the ACK source code (freely mixed with code that uses new-style prototypes...). 😓 Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should mostly fix the crashes which were observed on GitHub CI (e.g. https://github.com/davidgiven/ack/actions/runs/11410639087/job/31753347141) when building ACK for a macOS host on 64-bit ARM.
It turns out that Apple's ARM64 ABI handles variable arguments in variadic functions differently from named arguments
(https://developer.apple.com/documentation/xcode/application-binary-interfaces). Thus callees which want to call the variadic function sprint( ) must declare the correct prototype, otherwise they will pass arguments to it wrongly.