Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelectForm Bug Fixes + Improvements #1

Open
wants to merge 8 commits into
base: maintenance/gramps51
Choose a base branch
from

Conversation

dbareis
Copy link
Owner

@dbareis dbareis commented May 27, 2020

  • Cancel button now works (was alias for OK)

  • OK button now performs validation, only continues where possible.

  • Buttons no longer grab focus (except cancel which doesn't matter) thereby disabling interactive search

  • Added help button

  • Won't get multiple exceptions from the dialog, no longer need to kill gramps or respond to many exception dialogs to recover.

  • CTRL+F (or just start typing) interactive search now works in the form selection dialog. It filters out mismatches. Matches are case insensitive and match anywhere in the string.

  • Added Reset filter (doubles as an expand tree button)

  • Added compact/compress tree button. Called it Pack as I don't know how to not have buttons homogeneous (set_homogeneous,false doesn't work).

  • The form title wasn't being used. It now optionally is (it is if it begins with '/').
    e.g. title='/path1/subpath1.1/subpath1.1.1/census 1990'

  • when the form title isn't used then the dialog puts legacy entries into the same tree roots as in the past but may organise them by country or state below that.
    A Denmark census would be in the path 'Census/Denmark'.
    It also continues to use the source's name/title as the description (that is the title is ignored as previously).

    Filtering by "Denmark" is an easy way to get to them. In the US you can filter by state, or year of the census.

    EXAMPLE TITLES

    title="/Death/World Wide/Find a Grave (https:{s}{s}www.findagrave.com{s})"
    title="/Birth/Australia/Queensland (registry)"
    
    
  • The size & position of the select dialog is now remembered in "form.ini".

  • New "hover expand" checkbox (state saved in "form.ini"), off by default.
    {not shown in the pictures}

AllChoicesShown+FullyExpanded
Filtered for vic
Filtered for ustr

  * Cancel button now works (was alias for OK)

  * OK button now performs validation, only continues where possible.

  * Buttons no longer grab focus (except cancel which doesn't matter) thereby disabling interactive search

  * Added help button

  * Won't get multiple exceptions from the dialog, no longer need to kill gramps or respond to many exception dialogs to recover.

  * CTRL+F (or just start typing) interactive search now works in the form selection dialog.  It filters out mismatches.  Matches are case insensitive and match anywhere in the string.

  * Added Reset filter (doubles as an expand tree button)

  * Added compact/compress tree button. Called it Pack as I don't know how to not have buttons homogeneous (set_homogeneous,false doesn't work).

  * The form title wasn't being used. It now optionally is (it is if it begins with '/').
    e.g. title='/path1/subpath1.1/subpath1.1.1/census 1990'

  * when the form title isn't used then the dialog puts legacy entries into the same tree roots as in the past but may organise them by country or state below that.
    A Denmark census would be in the path 'Census/Denmark'.
    It also continues to use the source's name/title as the description (that is the title is ignored as previously).

    Filtering by "Denmark" is an easy way to get to them. In the US you can filter by state, or year of the census.

    EXAMPLE TITLES
    ~~~~~~~~~~~~~~
    title="/Death/World Wide/Find a Grave (https:{s}{s}www.findagrave.com{s})"
    title="/Birth/Australia/Queensland (registry)"

  * The size & position of the select dialog is now remembered in "form.ini".

  * New "hover expand" checkbox (state saved in "form.ini"), off by default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant