Tests: Use monkeypatch.context to avoid side effects on pytest #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test fixes aren't included in the changelog I presume? Don't see any explicit note about what contribution should be listed in the changelog but it appears test fixes aren't included. |
* Otherwise this mocked attribute would affect pytest negatively when running tests with --verbose. See-Also: dbcli#1152 (comment) Signed-off-by: Alfred Wingate <[email protected]>
parona-source
force-pushed
the
terminal_size_mocking
branch
from
86a994c
to
692d37e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See-Also: #1152 (comment)
Description
#1152 had a side effect of breaking pytest when invoked with --verbose, this pr use monkeypatch.context so that setattr doesnt affect pytest itself.
Checklist
changelog.md.AUTHORSfile (or it's already there).